annotate lib/opendir-safer.c @ 17363:5a51fb7777a9

sys_select, sys_time: port 2013-01-30 Solaris 2.6 fix to Cygwin Problem reported by Marco Atzeri in <http://lists.gnu.org/archive/html/bug-gnulib/2013-03/msg00000.html>. * lib/sys_select.in.h [HAVE_SYS_SELECT_H && _CYGWIN_SYS_TIME_H]: Simply delegate to the system <sys/select.h> in this case too. Also, pay attention to _GL_SYS_SELECT_H_REDIRECT_FROM_SYS_TIME_H only if OSF/1, since otherwise Cygwin breaks, and it doesn't seem to be needed on Solaris either. * lib/sys_time.in.h [_CYGWIN_SYS_TIME_H]: Simply delgate to the system <sys/time.h> in this case.
author Paul Eggert <eggert@cs.ucla.edu>
date Tue, 19 Mar 2013 09:08:47 -0700
parents e542fd46ad6f
children 344018b6e5d7
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
11936
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
1 /* Invoke opendir, but avoid some glitches.
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
2
17249
e542fd46ad6f maint: update all copyright year number ranges
Eric Blake <eblake@redhat.com>
parents: 16201
diff changeset
3 Copyright (C) 2009-2013 Free Software Foundation, Inc.
11936
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
4
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
5 This program is free software: you can redistribute it and/or modify
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
6 it under the terms of the GNU General Public License as published by
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
7 the Free Software Foundation; either version 3 of the License, or
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
8 (at your option) any later version.
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
9
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
10 This program is distributed in the hope that it will be useful,
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
11 but WITHOUT ANY WARRANTY; without even the implied warranty of
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
13 GNU General Public License for more details.
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
14
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
15 You should have received a copy of the GNU General Public License
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
16 along with this program. If not, see <http://www.gnu.org/licenses/>. */
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
17
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
18 /* Written by Eric Blake. */
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
19
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
20 #include <config.h>
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
21
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
22 #include "dirent-safer.h"
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
23
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
24 #include <errno.h>
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
25 #include <unistd.h>
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
26 #include "unistd-safer.h"
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
27
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
28 /* Like opendir, but do not clobber stdin, stdout, or stderr. */
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
29
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
30 DIR *
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
31 opendir_safer (char const *name)
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
32 {
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
33 DIR *dp = opendir (name);
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
34
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
35 if (dp)
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
36 {
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
37 int fd = dirfd (dp);
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
38
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
39 if (0 <= fd && fd <= STDERR_FILENO)
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
40 {
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
41 /* If fdopendir is native (as on Linux), then it is safe to
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
42 assume dirfd(fdopendir(n))==n. If we are using the
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
43 gnulib module fdopendir, then this guarantee is not met,
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
44 but fdopendir recursively calls opendir_safer up to 3
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
45 times to at least get a safe fd. If fdopendir is not
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
46 present but dirfd is accurate (as on cygwin 1.5.x), then
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
47 we recurse up to 3 times ourselves. Finally, if dirfd
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
48 always fails (as on mingw), then we are already safe. */
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
49 DIR *newdp;
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
50 int e;
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
51 #if HAVE_FDOPENDIR || GNULIB_FDOPENDIR
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
52 int f = dup_safer (fd);
14810
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
53 if (f < 0)
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
54 {
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
55 e = errno;
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
56 newdp = NULL;
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
57 }
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
58 else
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
59 {
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
60 newdp = fdopendir (f);
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
61 e = errno;
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
62 if (! newdp)
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
63 close (f);
fdcc880c0998 opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
64 }
11936
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
65 #else /* !FDOPENDIR */
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
66 newdp = opendir_safer (name);
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
67 e = errno;
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
68 #endif
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
69 closedir (dp);
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
70 errno = e;
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
71 dp = newdp;
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
72 }
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
73 }
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
74
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
75 return dp;
a126d5b22410 dirent-safer: new module
Eric Blake <ebb9@byu.net>
parents:
diff changeset
76 }