Mercurial > gnulib
comparison lib/xmemdup0.c @ 40214:452ab00796c7
Fix undefined behaviour.
* lib/bitrotate.h (rotl16, rotr16, rotl8, rotr8): Case x to
'unsigned int', to avoid shift operations on 'int'.
* lib/xmemdup0.c (xmemdup0): Don't invoke memcpy with a zero size.
* tests/test-count-leading-zeros.c (main): Use a random number that has
as many bits as TYPE, not only 2*15 or 2*31 bits.
* tests/test-count-trailing-zeros.c (main): Likewise.
* tests/test-count-one-bits.c (main): Likewise.
* tests/test-memmem.c: Don't include "null-ptr.h".
(main): Use zerosize_ptr() instead of null_ptr().
* modules/memmem-tests (Files): Remove tests/null-ptr.h.
author | Bruno Haible <bruno@clisp.org> |
---|---|
date | Sat, 09 Mar 2019 20:32:25 +0100 |
parents | b06060465f09 |
children |
comparison
equal
deleted
inserted
replaced
40213:cc3fed3b7788 | 40214:452ab00796c7 |
---|---|
36 | 36 |
37 char * | 37 char * |
38 xmemdup0 (void const *p, size_t s) | 38 xmemdup0 (void const *p, size_t s) |
39 { | 39 { |
40 char *result = xcharalloc (s + 1); | 40 char *result = xcharalloc (s + 1); |
41 memcpy (result, p, s); | 41 if (s > 0) |
42 memcpy (result, p, s); | |
42 result[s] = 0; | 43 result[s] = 0; |
43 return result; | 44 return result; |
44 } | 45 } |