Mercurial > gnulib
diff top/maint.mk @ 12208:a377ab624fcc
maint: detect usage(1) and other suspicious exits
* top/maint.mk (sc_prohibit_magic_number_exit): New rule.
Signed-off-by: Eric Blake <ebb9@byu.net>
| author | Eric Blake <ebb9@byu.net> |
|---|---|
| date | Thu, 29 Oct 2009 07:29:26 -0600 |
| parents | b7b81ca175f4 |
| children | 86929e33bdad |
line wrap: on
line diff
--- a/top/maint.mk Thu Oct 29 11:52:34 2009 +0100 +++ b/top/maint.mk Thu Oct 29 07:29:26 2009 -0600 @@ -156,6 +156,12 @@ { echo '$(ME): use STREQ in place of the above uses of str''cmp' \ 1>&2; exit 1; } || : +# Pass EXIT_*, not number, to usage, exit, and error (when exiting) +sc_prohibit_magic_number_exit: + @re='\<(usage|exit) ?\([0-9]|\<error ?\([1-9][0-9]*,' \ + msg='use EXIT_* values rather than magic number' \ + $(_prohibit_regexp) + # Using EXIT_SUCCESS as the first argument to error is misleading, # since when that parameter is 0, error does not exit. Use `0' instead. sc_error_exit_success: