Mercurial > gnulib
changeset 9846:25b01b718f02
Don't compare actual signbit return values.
* tests/test-strtod.c (main): Rather, compare only their
zero/non-zero nature.
| author | Jim Meyering <meyering@redhat.com> |
|---|---|
| date | Mon, 31 Mar 2008 19:22:06 +0200 |
| parents | 7898b15f2c3f |
| children | bb111aa32127 |
| files | ChangeLog tests/test-strtod.c |
| diffstat | 2 files changed, 14 insertions(+), 8 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Mon Mar 31 11:03:28 2008 -0700 +++ b/ChangeLog Mon Mar 31 19:22:06 2008 +0200 @@ -1,3 +1,9 @@ +2008-03-31 Jim Meyering <meyering@redhat.com> + + Don't compare actual signbit return values. + * tests/test-strtod.c (main): Rather, compare only their + zero/non-zero nature. + 2008-03-31 Eric Blake <ebb9@byu.net> More strtod documentation.
--- a/tests/test-strtod.c Mon Mar 31 11:03:28 2008 -0700 +++ b/tests/test-strtod.c Mon Mar 31 19:22:06 2008 +0200 @@ -280,7 +280,7 @@ char *ptr; double result = strtod (input, &ptr); ASSERT (result == 0.0); - ASSERT (signbit (result) == signbit (-0.0)); /* IRIX 6.5 */ + ASSERT (!!signbit (result) == !!signbit (-0.0)); /* IRIX 6.5 */ ASSERT (ptr == input + 2); ASSERT (errno == 0); } @@ -366,7 +366,7 @@ char *ptr; double result = strtod (input, &ptr); ASSERT (result == 0.0); - ASSERT (signbit (result) == signbit (-0.0)); /* MacOS X 10.3, FreeBSD 6.2, IRIX 6.5 */ + ASSERT (!!signbit (result) == !!signbit (-0.0)); /* MacOS X 10.3, FreeBSD 6.2, IRIX 6.5 */ ASSERT (ptr == input + 2); /* glibc-2.3.6, MacOS X 10.3, FreeBSD 6.2 */ ASSERT (errno == 0); } @@ -480,7 +480,7 @@ 0 on negative underflow, even though quality of implementation demands preserving the sign. Disable this test until fixed glibc is more prevalent. */ - ASSERT (signbit (result) == signbit (-0.0)); /* glibc-2.3.6, mingw */ + ASSERT (!!signbit (result) == !!signbit (-0.0)); /* glibc-2.3.6, mingw */ #endif ASSERT (ptr == input + 10); ASSERT (errno == ERANGE); @@ -548,7 +548,7 @@ # if 0 /* Sign bits of NaN is a portability sticking point, not worth worrying about. */ - ASSERT (signbit (result1) != signbit (result2)); /* glibc-2.3.6, IRIX 6.5, OSF/1 5.1, mingw */ + ASSERT (!!signbit (result1) != !!signbit (result2)); /* glibc-2.3.6, IRIX 6.5, OSF/1 5.1, mingw */ # endif ASSERT (ptr1 == input + 4); /* OpenBSD 4.0, IRIX 6.5, OSF/1 5.1, Solaris 2.5.1, mingw */ ASSERT (ptr2 == input + 4); /* OpenBSD 4.0, IRIX 6.5, OSF/1 5.1, Solaris 2.5.1, mingw */ @@ -573,7 +573,7 @@ #ifdef NAN ASSERT (isnan (result1)); /* OpenBSD 4.0, HP-UX 11.11, IRIX 6.5, OSF/1 5.1, mingw */ ASSERT (isnan (result2)); /* OpenBSD 4.0, HP-UX 11.11, IRIX 6.5, OSF/1 5.1, mingw */ - ASSERT (signbit (result1) == signbit (result2)); + ASSERT (!!signbit (result1) == !!signbit (result2)); ASSERT (ptr1 == input + 4); /* OpenBSD 4.0, HP-UX 11.11, IRIX 6.5, OSF/1 5.1, Solaris 2.5.1, mingw */ ASSERT (ptr2 == input + 4); /* OpenBSD 4.0, HP-UX 11.11, IRIX 6.5, OSF/1 5.1, Solaris 2.5.1, mingw */ ASSERT (errno == 0); @@ -600,7 +600,7 @@ # if 0 /* Sign bits of NaN is a portability sticking point, not worth worrying about. */ - ASSERT (signbit (result1) != signbit (result2)); /* glibc-2.3.6, IRIX 6.5, OSF/1 5.1, mingw */ + ASSERT (!!signbit (result1) != !!signbit (result2)); /* glibc-2.3.6, IRIX 6.5, OSF/1 5.1, mingw */ # endif ASSERT (ptr1 == input + 6); /* glibc-2.3.6, MacOS X 10.3, FreeBSD 6.2, OpenBSD 4.0, AIX 5.1, HP-UX 11.11, IRIX 6.5, OSF/1 5.1, mingw */ ASSERT (ptr2 == input + 6); /* glibc-2.3.6, MacOS X 10.3, FreeBSD 6.2, OpenBSD 4.0, AIX 5.1, HP-UX 11.11, IRIX 6.5, OSF/1 5.1, mingw */ @@ -647,7 +647,7 @@ # if 0 /* Sign bits of NaN is a portability sticking point, not worth worrying about. */ - ASSERT (signbit (result1) != signbit (result2)); /* glibc-2.3.6, IRIX 6.5, OSF/1 5.1, mingw */ + ASSERT (!!signbit (result1) != !!signbit (result2)); /* glibc-2.3.6, IRIX 6.5, OSF/1 5.1, mingw */ # endif ASSERT (ptr1 == input + 7); /* glibc-2.3.6, OpenBSD 4.0, AIX 5.1, HP-UX 11.11, IRIX 6.5, OSF/1 5.1, mingw */ ASSERT (ptr2 == input + 7); /* glibc-2.3.6, OpenBSD 4.0, AIX 5.1, HP-UX 11.11, IRIX 6.5, OSF/1 5.1, mingw */ @@ -829,7 +829,7 @@ input[m] = '\0'; result = strtod (input, &ptr); ASSERT (result == 0.0); - ASSERT (signbit (result) == signbit (-0.0)); /* IRIX 6.5 */ + ASSERT (!!signbit (result) == !!signbit (-0.0)); /* IRIX 6.5 */ ASSERT (ptr == input + m); ASSERT (errno == 0); }