comparison libinterp/corefcn/toplev.cc @ 31110:670a0d878af1

eliminate WHO arguments from interpreter-private functions * interpreter-private.h, inpterpreter-private.cc (__get_interpreter__, __get_dynamic_loader__, __get_error_system__, __get_gh_manager__, __get_help_system__, __get_input_system__, __get_load_path__, __get_load_save_system__, __get_event_manager__, __get_output_system__, __get_type_info__, __get_symbol_table__, __get_current_scope__, __require_current_scope__, __get_evaluator__, __get_bp_table__, __get_child_list__, __get_cdef_manager__, __get_display_info__, __get_gtk_manager__): Eliminate WHO argument. Previously, it was never displayed by __get_interpreter__. And, as pointed out by Petter Tomner in patch #10216, passing a std::string object could have performance issues. (__get_interpreter__): Eliminate useless call to error. Display message to std::cerr then abort.
author John W. Eaton <jwe@octave.org>
date Wed, 22 Jun 2022 12:48:59 -0400
parents 32d2b6604a9f
children
comparison
equal deleted inserted replaced
31109:90549b20fb28 31110:670a0d878af1
111 unwind_protect frame; 111 unwind_protect frame;
112 112
113 iprocstream *cmd = new iprocstream (cmd_str.c_str ()); 113 iprocstream *cmd = new iprocstream (cmd_str.c_str ());
114 frame.add_delete (cmd); 114 frame.add_delete (cmd);
115 115
116 child_list& kids 116 child_list& kids = __get_child_list__ ();
117 = __get_child_list__ ("run_command_and_return_output");
118 frame.add (&child_list::remove, kids, cmd->pid ()); 117 frame.add (&child_list::remove, kids, cmd->pid ());
119 118
120 if (! *cmd) 119 if (! *cmd)
121 error ("system: unable to start subprocess for '%s'", cmd_str.c_str ()); 120 error ("system: unable to start subprocess for '%s'", cmd_str.c_str ());
122 121