Mercurial > jwe > octave
comparison liboctave/numeric/CmplxSVD.cc @ 21136:7cac4e7458f2
maint: clean up code around calls to current_liboctave_error_handler.
Remove statements after call to handler that are no longer reachable.
Place input validation first and immediately call handler if necessary.
Change if/error_handler/else to if/error_handler and re-indent code.
* Array-util.cc, Array.cc, CColVector.cc, CDiagMatrix.cc, CMatrix.cc,
CNDArray.cc, CRowVector.cc, CSparse.cc, DiagArray2.cc, MArray.cc,
PermMatrix.cc, Sparse.cc, Sparse.h, chMatrix.cc, chNDArray.cc, dColVector.cc,
dDiagMatrix.cc, dMatrix.cc, dNDArray.cc, dRowVector.cc, dSparse.cc,
fCColVector.cc, fCDiagMatrix.cc, fCMatrix.cc, fCNDArray.cc, fCRowVector.cc,
fColVector.cc, fDiagMatrix.cc, fMatrix.cc, fNDArray.cc, fRowVector.cc,
idx-vector.cc, CmplxAEPBAL.cc, CmplxCHOL.cc, CmplxGEPBAL.cc, CmplxHESS.cc,
CmplxLU.cc, CmplxQR.cc, CmplxSCHUR.cc, CmplxSVD.cc, DASPK.cc, EIG.cc, LSODE.cc,
Quad.cc, SparseCmplxCHOL.cc, SparseCmplxLU.cc, SparseCmplxQR.cc, SparseQR.cc,
SparsedbleCHOL.cc, SparsedbleLU.cc, base-lu.cc, bsxfun-defs.cc, dbleAEPBAL.cc,
dbleCHOL.cc, dbleGEPBAL.cc, dbleHESS.cc, dbleLU.cc, dbleQR.cc, dbleSCHUR.cc,
dbleSVD.cc, eigs-base.cc, fCmplxAEPBAL.cc, fCmplxCHOL.cc, fCmplxLU.cc,
fCmplxQR.cc, fCmplxSCHUR.cc, fEIG.cc, floatAEPBAL.cc, floatCHOL.cc,
floatGEPBAL.cc, floatHESS.cc, floatLU.cc, floatQR.cc, floatSCHUR.cc,
floatSVD.cc, lo-specfun.cc, oct-fftw.cc, oct-rand.cc, oct-spparms.cc,
sparse-base-chol.cc, sparse-dmsolve.cc, file-ops.cc, lo-sysdep.cc,
mach-info.cc, oct-env.cc, oct-syscalls.cc, cmd-edit.cc, cmd-hist.cc,
data-conv.cc, lo-ieee.cc, lo-regexp.cc, oct-base64.cc, oct-shlib.cc,
pathsearch.cc, singleton-cleanup.cc, sparse-util.cc, unwind-prot.cc:
Remove statements after call to handler that are no longer reachable.
Place input validation first and immediately call handler if necessary.
Change if/error_handler/else to if/error_handler and re-indent code.
author | Rik <rik@octave.org> |
---|---|
date | Sat, 23 Jan 2016 13:52:03 -0800 |
parents | 4197fc428c7d |
children | f7121e111991 |
comparison
equal
deleted
inserted
replaced
21135:95da3bc8a281 | 21136:7cac4e7458f2 |
---|---|
55 | 55 |
56 ComplexMatrix | 56 ComplexMatrix |
57 ComplexSVD::left_singular_matrix (void) const | 57 ComplexSVD::left_singular_matrix (void) const |
58 { | 58 { |
59 if (type_computed == SVD::sigma_only) | 59 if (type_computed == SVD::sigma_only) |
60 { | 60 (*current_liboctave_error_handler) |
61 (*current_liboctave_error_handler) | 61 ("ComplexSVD: U not computed because type == SVD::sigma_only"); |
62 ("ComplexSVD: U not computed because type == SVD::sigma_only"); | 62 |
63 return ComplexMatrix (); | 63 return left_sm; |
64 } | |
65 else | |
66 return left_sm; | |
67 } | 64 } |
68 | 65 |
69 ComplexMatrix | 66 ComplexMatrix |
70 ComplexSVD::right_singular_matrix (void) const | 67 ComplexSVD::right_singular_matrix (void) const |
71 { | 68 { |
72 if (type_computed == SVD::sigma_only) | 69 if (type_computed == SVD::sigma_only) |
73 { | 70 (*current_liboctave_error_handler) |
74 (*current_liboctave_error_handler) | 71 ("ComplexSVD: V not computed because type == SVD::sigma_only"); |
75 ("ComplexSVD: V not computed because type == SVD::sigma_only"); | 72 |
76 return ComplexMatrix (); | 73 return right_sm; |
77 } | |
78 else | |
79 return right_sm; | |
80 } | 74 } |
81 | 75 |
82 octave_idx_type | 76 octave_idx_type |
83 ComplexSVD::init (const ComplexMatrix& a, SVD::type svd_type, | 77 ComplexSVD::init (const ComplexMatrix& a, SVD::type svd_type, |
84 SVD::driver svd_driver) | 78 SVD::driver svd_driver) |