Mercurial > jwe > octave
changeset 24095:eadaf557ca09
make wizard web connection prompt consistent with default setting (bug #52090)
* welcome-wizard.cc (welcome_wizard::welcome_wizard): Initialize
m_allow_web_connect_state to false.
(setup_community_news::setup_community_news): Initialize m_checkbox to unchecked
and reword associated m_message.
| author | Mike Miller <mtmiller@octave.org> |
|---|---|
| date | Sun, 24 Sep 2017 11:52:02 -0700 |
| parents | 1265c7f0119a |
| children | 8f3db1ac7877 |
| files | libgui/src/welcome-wizard.cc |
| diffstat | 1 files changed, 6 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/libgui/src/welcome-wizard.cc Sun Sep 24 09:52:41 2017 +0200 +++ b/libgui/src/welcome-wizard.cc Sun Sep 24 11:52:02 2017 -0700 @@ -50,7 +50,7 @@ welcome_wizard::welcome_wizard (QWidget *p) : QDialog (p), m_page_ctor_list (), m_page_list_iterator (), m_current_page (initial_page::create (this)), - m_allow_web_connect_state (true) + m_allow_web_connect_state (false) { m_page_ctor_list.push_back (initial_page::create); m_page_ctor_list.push_back (setup_community_news::create); @@ -198,9 +198,9 @@ m_message->setText (tr ("<html><body>\n" - "<p>When the Octave GUI starts, it will check the Octave web site for current news and information about the Octave community.\n" + "<p>When Octave starts, it will optionally check the Octave web site for current news and information about the Octave community.\n" "The check will happen at most once each day and news will only be displayed if there is something new since the last time you viewed the news.</p>\n" - "<p>You may also view the news by selecting the \"Community News\" item in the \"Help\" menu in the GUI, or by visiting\n" + "<p>You may also view the news by selecting the \"Community News\" item in the \"Help\" menu, or by visiting\n" "<a href=\"http://octave.org/community-news.html\">http://octave.org/community-news.html</a>.</p>\n" "</body></html>")); m_message->setWordWrap (true); @@ -220,7 +220,9 @@ QHBoxLayout *checkbox_layout = new QHBoxLayout; - m_checkbox->setCheckState (Qt::Checked); + // FIXME: Synchronize the initial state of this checkbox with the default + // value of "news/allow_web_connection" stored elsewhere. + m_checkbox->setCheckState (Qt::Unchecked); m_checkbox_message->setText (tr ("<html><head>\n"