diff liboctave/numeric/lo-specfun.cc @ 18676:5bd1ca29c5f0

Clean up questionable code bits identified by clang sanitize. * data.cc (Fnorm): in %!test, don't test with a single value which exceeds range of single. * find.cc (find_nonzero_elem_idx): Remove unused variable assignment to n_to_find. * load-save.cc (Fsave): Declare argc just before usage. * ls-hdf5.cc (hdf5_read_next_data): Return from function immediately if type is unrecognized. * oct-stream.cc (octave_stream::read): Eliminate unnecessary initialization of elts_to_read. * octave-link.cc (F__octave_link_file_dialog__): Eliminate unnecessary initialization of nel. * pr-output.cc (set_real_format): Don't assign to function input variable digits. * str2double.cc (single_num): Initialize return value num at start of function. * ov-complex.cc (octave_complex::double_value, octave_complex::float_value): Eliminate unnecessary initialization of retval. * ov-flt-complex.cc (octave_float_complex::double_value, octave_float_complex::float_value): Eliminate unnecessary initialization of retval. * CSparse.cc (SparseComplexMatrix::inverse): Remove useless asignment to typ. * CSparse.cc (SparseComplexMatrix::bsolve): Initialize anorm before using in comparison. * MatrixType.cc (matrix_complex_probe): Initialize typ to MatrixType::Unknown. * dSparse.cc (SparseMatrix::inverse): Remove useless assignment to typ. * dSparse.cc (SparseMatrix::bsolve): Initialize anorm before using in comparison. * lo-specfun.cc (gammainc): Remove useless assignment to err. * data-conv.cc (oct_data_conv::string_to_data_type): Remove useless assignment to input_is_output. * str-vec.cc (string_vector::list_in_columns): Remove useless assignment to nc.
author Rik <rik@octave.org>
date Fri, 25 Apr 2014 10:02:10 -0700
parents 8e056300994b
children 6113e0c6920b
line wrap: on
line diff
--- a/liboctave/numeric/lo-specfun.cc	Thu Apr 24 14:03:46 2014 -0700
+++ b/liboctave/numeric/lo-specfun.cc	Fri Apr 25 10:02:10 2014 -0700
@@ -2578,12 +2578,8 @@
   err = false;
 
   if (a < 0.0 || x < 0.0)
-    {
-      (*current_liboctave_error_handler)
-        ("gammainc: A and X must be non-negative");
-
-      err = true;
-    }
+    (*current_liboctave_error_handler)
+      ("gammainc: A and X must be non-negative");
   else
     F77_XFCN (xgammainc, XGAMMAINC, (a, x, retval));
 
@@ -2783,12 +2779,8 @@
   err = false;
 
   if (a < 0.0 || x < 0.0)
-    {
-      (*current_liboctave_error_handler)
-        ("gammainc: A and X must be non-negative");
-
-      err = true;
-    }
+    (*current_liboctave_error_handler)
+      ("gammainc: A and X must be non-negative");
   else
     F77_XFCN (xsgammainc, XSGAMMAINC, (a, x, retval));