view libinterp/octave-value/ov-dld-fcn.cc @ 18676:5bd1ca29c5f0

Clean up questionable code bits identified by clang sanitize. * data.cc (Fnorm): in %!test, don't test with a single value which exceeds range of single. * find.cc (find_nonzero_elem_idx): Remove unused variable assignment to n_to_find. * load-save.cc (Fsave): Declare argc just before usage. * ls-hdf5.cc (hdf5_read_next_data): Return from function immediately if type is unrecognized. * oct-stream.cc (octave_stream::read): Eliminate unnecessary initialization of elts_to_read. * octave-link.cc (F__octave_link_file_dialog__): Eliminate unnecessary initialization of nel. * pr-output.cc (set_real_format): Don't assign to function input variable digits. * str2double.cc (single_num): Initialize return value num at start of function. * ov-complex.cc (octave_complex::double_value, octave_complex::float_value): Eliminate unnecessary initialization of retval. * ov-flt-complex.cc (octave_float_complex::double_value, octave_float_complex::float_value): Eliminate unnecessary initialization of retval. * CSparse.cc (SparseComplexMatrix::inverse): Remove useless asignment to typ. * CSparse.cc (SparseComplexMatrix::bsolve): Initialize anorm before using in comparison. * MatrixType.cc (matrix_complex_probe): Initialize typ to MatrixType::Unknown. * dSparse.cc (SparseMatrix::inverse): Remove useless assignment to typ. * dSparse.cc (SparseMatrix::bsolve): Initialize anorm before using in comparison. * lo-specfun.cc (gammainc): Remove useless assignment to err. * data-conv.cc (oct_data_conv::string_to_data_type): Remove useless assignment to input_is_output. * str-vec.cc (string_vector::list_in_columns): Remove useless assignment to nc.
author Rik <rik@octave.org>
date Fri, 25 Apr 2014 10:02:10 -0700
parents d63878346099
children
line wrap: on
line source

/*

Copyright (C) 1996-2013 John W. Eaton

This file is part of Octave.

Octave is free software; you can redistribute it and/or modify it
under the terms of the GNU General Public License as published by the
Free Software Foundation; either version 3 of the License, or (at your
option) any later version.

Octave is distributed in the hope that it will be useful, but WITHOUT
ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
for more details.

You should have received a copy of the GNU General Public License
along with Octave; see the file COPYING.  If not, see
<http://www.gnu.org/licenses/>.

*/

#ifdef HAVE_CONFIG_H
#include <config.h>
#endif

#include "oct-shlib.h"

#include <defaults.h>
#include "dynamic-ld.h"
#include "error.h"
#include "oct-obj.h"
#include "ov-dld-fcn.h"
#include "ov.h"

DEFINE_OCTAVE_ALLOCATOR (octave_dld_function);

DEFINE_OV_TYPEID_FUNCTIONS_AND_DATA (octave_dld_function,
                                     "dynamically-linked function",
                                     "dynamically-linked function");


octave_dld_function::octave_dld_function
  (octave_builtin::fcn ff, const octave_shlib& shl,
   const std::string& nm, const std::string& ds)
  : octave_builtin (ff, nm, ds), sh_lib (shl)
{
  mark_fcn_file_up_to_date (time_parsed ());

  std::string file_name = fcn_file_name ();

  system_fcn_file
    = (! file_name.empty ()
       && Voct_file_dir == file_name.substr (0, Voct_file_dir.length ()));
}

octave_dld_function::~octave_dld_function (void)
{
  octave_dynamic_loader::remove_oct (my_name, sh_lib);
}

std::string
octave_dld_function::fcn_file_name (void) const
{
  return sh_lib.file_name ();
}

octave_time
octave_dld_function::time_parsed (void) const
{
  return sh_lib.time_loaded ();
}

// Note: this wrapper around the octave_dld_function constructor is
//       necessary to work around a MSVC limitation handling in
//       virtual destructors that prevents unloading a dynamic module
//       before *all* objects (of class using a virtual dtor) have
//       been fully deleted; indeed, MSVC attaches auto-generated code
//       (scalar deleting destructor) to objects created in a dynamic
//       module, and this code will be executed in the dynamic module
//       context at object deletion; unloading the dynamic module
//       before objects have been deleted will make the "delete" code
//       of objects to point to an invalid code segment.

octave_dld_function*
octave_dld_function::create (octave_builtin::fcn ff, const octave_shlib& shl,
                             const std::string& nm, const std::string& ds)
{
  return new octave_dld_function (ff, shl, nm, ds);
}