# HG changeset patch # User Jaroslav Hajek # Date 1279866039 -7200 # Node ID 0eb323b71957dcb52a325aca01063cf6a1b27650 # Parent 83896a06adaf2d6dfad7301d5c4cc387bd7bafcf simplify narrowing of diagonal matrices diff -r 83896a06adaf -r 0eb323b71957 src/ChangeLog --- a/src/ChangeLog Fri Jul 23 08:08:28 2010 +0200 +++ b/src/ChangeLog Fri Jul 23 08:20:39 2010 +0200 @@ -1,3 +1,14 @@ +2010-07-23 Jaroslav Hajek + + * ov-re-diag.cc (octave_diag_matrix::try_narrowing_conversion): Remove + redundant cast. + * ov-flt-re-diag.cc + (octave_float_diag_matrix::try_narrowing_conversion): Ditto. + * ov-cx-diag.cc + (octave_complex_diag_matrix::try_narrowing_conversion): Ditto. + * ov-flt-cx-diag.cc + (octave_float_complex_diag_matrix::try_narrowing_conversion): Ditto. + 2010-07-23 Jaroslav Hajek * pt-mat.cc (do_single_type_concat_no_mutate): Remove. diff -r 83896a06adaf -r 0eb323b71957 src/ov-cx-diag.cc --- a/src/ov-cx-diag.cc Fri Jul 23 08:08:28 2010 +0200 +++ b/src/ov-cx-diag.cc Fri Jul 23 08:20:39 2010 +0200 @@ -78,8 +78,7 @@ if (matrix.nelem () == 1) { - // FIXME: the proxy mechanism of DiagArray2 causes problems here. - retval = new octave_complex (Complex (matrix (0, 0))); + retval = new octave_complex (matrix (0, 0)); octave_base_value *rv2 = retval->try_narrowing_conversion (); if (rv2) { diff -r 83896a06adaf -r 0eb323b71957 src/ov-flt-cx-diag.cc --- a/src/ov-flt-cx-diag.cc Fri Jul 23 08:08:28 2010 +0200 +++ b/src/ov-flt-cx-diag.cc Fri Jul 23 08:20:39 2010 +0200 @@ -62,8 +62,7 @@ if (matrix.nelem () == 1) { - // FIXME: the proxy mechanism of DiagArray2 causes problems here. - retval = new octave_float_complex (FloatComplex (matrix (0, 0))); + retval = new octave_float_complex (matrix (0, 0)); octave_base_value *rv2 = retval->try_narrowing_conversion (); if (rv2) { diff -r 83896a06adaf -r 0eb323b71957 src/ov-flt-re-diag.cc --- a/src/ov-flt-re-diag.cc Fri Jul 23 08:08:28 2010 +0200 +++ b/src/ov-flt-re-diag.cc Fri Jul 23 08:20:39 2010 +0200 @@ -59,9 +59,8 @@ { octave_base_value *retval = 0; - // FIXME: the proxy mechanism of DiagArray2 causes problems here. if (matrix.nelem () == 1) - retval = new octave_float_scalar (float (matrix (0, 0))); + retval = new octave_float_scalar (matrix (0, 0)); return retval; } diff -r 83896a06adaf -r 0eb323b71957 src/ov-re-diag.cc --- a/src/ov-re-diag.cc Fri Jul 23 08:08:28 2010 +0200 +++ b/src/ov-re-diag.cc Fri Jul 23 08:20:39 2010 +0200 @@ -74,9 +74,8 @@ { octave_base_value *retval = 0; - // FIXME: the proxy mechanism of DiagArray2 causes problems here. if (matrix.nelem () == 1) - retval = new octave_scalar (double (matrix (0, 0))); + retval = new octave_scalar (matrix (0, 0)); return retval; }