# HG changeset patch
# User Doug Stewart <doug.dastew@gmail.com
# Date 1423517093 18000
# Node ID 8724af455b113d88e3d64341b72d81de68de2ab5
# Parent  8064b5cdbc11a25498da5189c0830827bde08c4f
freqz.m: Add 1 more point to the plot output (bug #438950).

* freqz.m: Add 1 more point to the plot output.  Use better input validation.

diff -r 8064b5cdbc11 -r 8724af455b11 scripts/signal/freqz.m
--- a/scripts/signal/freqz.m	Sun Feb 08 13:09:43 2015 +0100
+++ b/scripts/signal/freqz.m	Mon Feb 09 16:24:53 2015 -0500
@@ -22,7 +22,7 @@
 ## @deftypefnx {Function File} {[@var{h}, @var{w}] =} freqz (@var{b}, @var{a})
 ## @deftypefnx {Function File} {[@var{h}, @var{w}] =} freqz (@var{b}, @var{a}, @var{n})
 ## @deftypefnx {Function File} {@var{h} =} freqz (@var{b}, @var{a}, @var{w})
-## @deftypefnx {Function File} {[@dots{}] =} freqz (@dots{}, @var{Fs})
+## @deftypefnx {Function File} {[@var{h}, @var{w}] =} freqz (@dots{}, @var{Fs})
 ## @deftypefnx {Function File} {} freqz (@dots{})
 ##
 ## Return the complex frequency response @var{h} of the rational IIR filter
@@ -97,12 +97,18 @@
 
   if (isempty (b))
     b = 1;
+  elseif (! isvector (b))
+    error ("freqz: B must be a vector");
   endif
   if (isempty (a))
     a = 1;
+  elseif (! isvector (a))
+    error ("freqz: A must be a vector");
   endif
   if (isempty (n))
     n = 512;
+  elseif (isscalar (n) && n < 1)
+    error ("freqz: N must be a positive integer");
   endif
   if (isempty (region))
     if (isreal (b) && isreal (a))
@@ -121,6 +127,8 @@
   else
     freq_norm = false;
   endif
+  plot_output = (nargout == 0);
+  whole_region = strcmp (region, "whole");
 
   a = a(:);
   b = b(:);
@@ -147,14 +155,21 @@
       n = n * 2 .^ ceil (log2 (2*k/n));
     endif
 
-    if (strcmp (region, "whole"))
+    if (whole_region)
       N = n;
+      if (plot_output)
+        f = Fs * (0:n).' / N     # do 1 more for the plot
+      else
+        f = Fs * (0:n-1).' / N;
+      endif
     else
       N = 2*n;
+      if (plot_output)
+        n++;
+      endif
+      f = Fs * (0:n-1).' / N;
     endif
 
-    f = Fs * (0:n-1).' / N;
-
     pad_sz = N*ceil (k/N);
     b = postpad (b, pad_sz);
     a = postpad (a, pad_sz);
@@ -171,13 +186,16 @@
 
   h = hb ./ ha;
 
-  if (nargout != 0)
+  if (plot_output)
+    ## Plot and don't return values.
+    if (whole_region)
+      h(end+1) = h(1); # Solution is periodic.  Copy first value to end.
+    endif
+    freqz_plot (f, h, freq_norm);
+  else
     ## Return values and don't plot.
     h_r = h;
     f_r = f;
-  else
-    ## Plot and don't return values.
-    freqz_plot (f, h, freq_norm);
   endif
 
 endfunction
@@ -210,3 +228,6 @@
 %! [h3,f3] = freqz (b,a,32,"whole",320);
 %! assert (f3,[0:31]'*10,10*eps);
 
+%% Test input validation
+## FIXME: Need to put tests here and simplify the input validation in the main code.
+