# HG changeset patch # User Rik # Date 1401728725 25200 # Node ID 99d63a2e221b705761d831c2f142de763c4291ce # Parent 59975c3cea6b3f84f78a3b9c0cf5a2f295385dbe Mark internal sparse matrix implementation of atan2 as deprecated. * NEWS: Announce deprecation. * dSparse.h: Add GCC_ATTR_DEPRECATED to atan2 prototype declarations. diff -r 59975c3cea6b -r 99d63a2e221b NEWS --- a/NEWS Mon Jun 02 09:00:22 2014 -0700 +++ b/NEWS Mon Jun 02 10:05:25 2014 -0700 @@ -46,6 +46,11 @@ allow_noninteger_range_as_index do_braindead_shortcircuit_evaluation + + The internal function atan2 of the sparse matrix class has been deprecated + in Octave 4.0 and will be removed from Octave 4.4 (or whatever version is + the second major release after 4.0). Use the Fatan2 function with sparse + inputs as a replacement. --------------------------------------------------------- diff -r 59975c3cea6b -r 99d63a2e221b liboctave/array/dSparse.h --- a/liboctave/array/dSparse.h Mon Jun 02 09:00:22 2014 -0700 +++ b/liboctave/array/dSparse.h Mon Jun 02 10:05:25 2014 -0700 @@ -120,10 +120,13 @@ friend OCTAVE_API SparseMatrix real (const SparseComplexMatrix& a); friend OCTAVE_API SparseMatrix imag (const SparseComplexMatrix& a); - friend OCTAVE_API SparseMatrix atan2 (const double& x, const SparseMatrix& y); - friend OCTAVE_API SparseMatrix atan2 (const SparseMatrix& x, const double& y); + friend OCTAVE_API SparseMatrix atan2 (const double& x, const SparseMatrix& y) + GCC_ATTR_DEPRECATED ; + friend OCTAVE_API SparseMatrix atan2 (const SparseMatrix& x, const double& y) + GCC_ATTR_DEPRECATED ; friend OCTAVE_API SparseMatrix atan2 (const SparseMatrix& x, - const SparseMatrix& y); + const SparseMatrix& y) + GCC_ATTR_DEPRECATED ; SparseMatrix transpose (void) const {