# HG changeset patch # User John W. Eaton # Date 1381199755 14400 # Node ID d8d71c89fff2b50ecfb80f20cda14d5fdff1b1cd # Parent e5932e528721084a6c168be06631283fdb34cb5f eliminate unnecessary member variable in url_base_transfer class * url-transfer.h, url-transfer.cc (base_url_transfer::userpw): Delete member variable. (curl_transfer::init): Declare userpwd as a local variable. diff -r e5932e528721 -r d8d71c89fff2 liboctave/util/url-transfer.cc --- a/liboctave/util/url-transfer.cc Mon Oct 07 22:33:29 2013 -0400 +++ b/liboctave/util/url-transfer.cc Mon Oct 07 22:35:55 2013 -0400 @@ -658,7 +658,7 @@ SETOPT (CURLOPT_NOBODY, 1); // Set the username and password - userpwd = user; + std::string userpwd = user; if (! passwd.empty ()) userpwd += ":" + passwd; if (! userpwd.empty ()) diff -r e5932e528721 -r d8d71c89fff2 liboctave/util/url-transfer.h --- a/liboctave/util/url-transfer.h Mon Oct 07 22:33:29 2013 -0400 +++ b/liboctave/util/url-transfer.h Mon Oct 07 22:35:55 2013 -0400 @@ -47,7 +47,7 @@ friend class url_transfer; base_url_transfer (void) - : count (1), host_or_url (), userpwd (), valid (false), ftp (false), + : count (1), host_or_url (), valid (false), ftp (false), ascii_mode (false), ok (true), errmsg (), curr_istream (&std::cin), curr_ostream (&std::cout) { } @@ -56,12 +56,12 @@ const std::string& /* user_arg */, const std::string& /* passwd */, std::ostream& os) - : count (1), host_or_url (host), userpwd (), valid (false), ftp (true), + : count (1), host_or_url (host), valid (false), ftp (true), ascii_mode (false), ok (true), errmsg (), curr_istream (&std::cin), curr_ostream (&os) { } base_url_transfer (const std::string& url, std::ostream& os) - : count (1), host_or_url (url), userpwd (), valid (false), ftp (false), + : count (1), host_or_url (url), valid (false), ftp (false), ascii_mode (false), ok (true), errmsg (), curr_istream (&std::cin), curr_ostream (&os) { } @@ -141,7 +141,6 @@ // Host for ftp transfers or full URL for http requests. std::string host_or_url; - std::string userpwd; bool valid; bool ftp; bool ascii_mode;