# HG changeset patch # User John Donoghue # Date 1365249180 14400 # Node ID ee652dcc9eccf40fd2ac7719846c5a929bdd9297 # Parent aaf024ac8015fff1144eab9f7f698dc1332cb51b history_doc_widget context menu memory leak fix (bug #38675) * libgui/src/history-dockwidget.cc (history_dock_widget::ctxMenu): changed context menu creation from dynamic memory to stack created so that is is freed when function returns. diff -r aaf024ac8015 -r ee652dcc9ecc libgui/src/history-dockwidget.cc --- a/libgui/src/history-dockwidget.cc Thu Apr 04 22:22:17 2013 -0400 +++ b/libgui/src/history-dockwidget.cc Sat Apr 06 07:53:00 2013 -0400 @@ -81,10 +81,10 @@ } void history_dock_widget::ctxMenu(const QPoint &xpos) { - QMenu *menu = new QMenu; - menu->addAction(tr("Copy"), this, SLOT(handle_contextmenu_copy(bool))); - menu->addAction(tr("Evaluate"), this, SLOT(handle_contextmenu_evaluate(bool))); - menu->exec(_history_list_view->mapToGlobal(xpos)); + QMenu menu(this); + menu.addAction(tr("Copy"), this, SLOT(handle_contextmenu_copy(bool))); + menu.addAction(tr("Evaluate"), this, SLOT(handle_contextmenu_evaluate(bool))); + menu.exec(_history_list_view->mapToGlobal(xpos)); } void history_dock_widget::handle_contextmenu_copy(bool)