# HG changeset patch # User dbateman # Date 1174944180 0 # Node ID fa6312d937305fcf269b09a6461ee5e6c3b22577 # Parent 5dc550e1f4193f891fe0de14ab5c0ead9951c432 [project @ 2007-03-26 21:23:00 by dbateman] diff -r 5dc550e1f419 -r fa6312d93730 liboctave/ChangeLog --- a/liboctave/ChangeLog Mon Mar 26 18:11:58 2007 +0000 +++ b/liboctave/ChangeLog Mon Mar 26 21:23:00 2007 +0000 @@ -1,3 +1,15 @@ +2007-03-26 David Bateman + + * MatrixType.cc: Replace all uses of the method + octave_sparse_params::get_key ("bandden") with + octave_sparse_params::get_bandden (void). + (MatrixType::MatrixType (void)): Undo previous change but use + octave_sparse_params::get_bandden (void). + * oct-spparms.cc (get_bandden(void), do_get_bandden(void)): New + methods. + * oct-spparms.h (get_bandden(void), do_get_bandden(void)): + Declare them. + 2007-03-26 Luis Ortiz David Bateman diff -r 5dc550e1f419 -r fa6312d93730 liboctave/MatrixType.cc --- a/liboctave/MatrixType.cc Mon Mar 26 18:11:58 2007 +0000 +++ b/liboctave/MatrixType.cc Mon Mar 26 21:23:00 2007 +0000 @@ -36,7 +36,9 @@ // FIXME There is a large code duplication here MatrixType::MatrixType (void) - : typ (MatrixType::Unknown), sp_bandden (0), bandden (0), upper_band (0), + : typ (MatrixType::Unknown), + sp_bandden (octave_sparse_params::get_bandden()), + bandden (0), upper_band (0), lower_band (0), dense (false), full (false), nperm (0), perm (0) { } MatrixType::MatrixType (const MatrixType &a) @@ -186,7 +188,7 @@ (*current_liboctave_warning_handler) ("Calculating Sparse Matrix Type"); - sp_bandden = octave_sparse_params::get_key ("bandden"); + sp_bandden = octave_sparse_params::get_bandden(); bool maybe_hermitian = false; typ = MatrixType::Full; @@ -512,7 +514,7 @@ (*current_liboctave_warning_handler) ("Calculating Sparse Matrix Type"); - sp_bandden = octave_sparse_params::get_key ("bandden"); + sp_bandden = octave_sparse_params::get_bandden(); bool maybe_hermitian = false; typ = MatrixType::Full; @@ -825,7 +827,7 @@ } MatrixType::MatrixType (const matrix_type t, bool _full) : typ (MatrixType::Unknown), - sp_bandden (octave_sparse_params::get_key ("bandden")), + sp_bandden (octave_sparse_params::get_bandden()), bandden (0), upper_band (0), lower_band (0), dense (false), full (_full), nperm (0), perm (0) { @@ -841,7 +843,7 @@ MatrixType::MatrixType (const matrix_type t, const octave_idx_type np, const octave_idx_type *p, bool _full) : typ (MatrixType::Unknown), - sp_bandden (octave_sparse_params::get_key ("bandden")), + sp_bandden (octave_sparse_params::get_bandden()), bandden (0), upper_band (0), lower_band (0), dense (false), full (_full), nperm (0), perm (0) { @@ -861,7 +863,7 @@ MatrixType::MatrixType (const matrix_type t, const octave_idx_type ku, const octave_idx_type kl, bool _full) : typ (MatrixType::Unknown), - sp_bandden (octave_sparse_params::get_key ("bandden")), + sp_bandden (octave_sparse_params::get_bandden()), bandden (0), upper_band (0), lower_band (0), dense (false), full (_full), nperm (0), perm (0) { @@ -912,7 +914,7 @@ MatrixType::type (bool quiet) { if (typ != MatrixType::Unknown && (full || - sp_bandden == octave_sparse_params::get_key ("bandden"))) + sp_bandden == octave_sparse_params::get_bandden())) { if (!quiet && octave_sparse_params::get_key ("spumoni") != 0.) @@ -936,7 +938,7 @@ MatrixType::type (const SparseMatrix &a) { if (typ != MatrixType::Unknown && (full || - sp_bandden == octave_sparse_params::get_key ("bandden"))) + sp_bandden == octave_sparse_params::get_bandden())) { if (octave_sparse_params::get_key ("spumoni") != 0.) (*current_liboctave_warning_handler) @@ -969,7 +971,7 @@ MatrixType::type (const SparseComplexMatrix &a) { if (typ != MatrixType::Unknown && (full || - sp_bandden == octave_sparse_params::get_key ("bandden"))) + sp_bandden == octave_sparse_params::get_bandden())) { if (octave_sparse_params::get_key ("spumoni") != 0.) (*current_liboctave_warning_handler) diff -r 5dc550e1f419 -r fa6312d93730 liboctave/oct-spparms.cc --- a/liboctave/oct-spparms.cc Mon Mar 26 18:11:58 2007 +0000 +++ b/liboctave/oct-spparms.cc Mon Mar 26 21:23:00 2007 +0000 @@ -94,6 +94,12 @@ return instance_ok () ? instance->do_get_key (key) : octave_NaN; } +double +octave_sparse_params::get_bandden (void) +{ + return instance_ok () ? instance->do_get_bandden () : 0.0; +} + void octave_sparse_params::print_info (std::ostream& os, const std::string& prefix) { @@ -152,6 +158,12 @@ keys(11) = "umfpack"; } +double +octave_sparse_params::do_get_bandden (void) +{ + return params(10); +} + bool octave_sparse_params::do_set_vals (const NDArray& vals) { diff -r 5dc550e1f419 -r fa6312d93730 liboctave/oct-spparms.h --- a/liboctave/oct-spparms.h Mon Mar 26 18:11:58 2007 +0000 +++ b/liboctave/oct-spparms.h Mon Mar 26 21:23:00 2007 +0000 @@ -66,6 +66,8 @@ static double get_key (const std::string& key); + static double get_bandden (void); + static void print_info (std::ostream& os, const std::string& prefix); private: @@ -90,6 +92,8 @@ double do_get_key (const std::string& key); + double do_get_bandden (void); + void do_print_info (std::ostream& os, const std::string& prefix) const; void init_keys (void);