Mercurial > octave
comparison libinterp/corefcn/__ftp__.cc @ 31603:23520a50d74d stable
maint: Review C++ files for style and coding conventions.
* __ftp__.cc (F__ftp_cwd__, F__ftp_mget__),
__isprimelarge__.cc (F__isprimelarge__, F__pollardrho__),
debug.cc (Fdbclear), file-io.cc (Ftempdir):
Don't bother to define nargin if it is used only once in function.
Instead, just call args.length () for the one instance.
* data.cc (fill_matrix): Eliminate useless break statement after error() which
throws exception.
* qr.cc (Fqr),
__ode15__.cc (IDA::integrate, IDA::event, IDA::interpolate, IDA::outputfun):
Use true or false rather than 0 or 1 when assigning to bool variables.
maint: Review C++ files for style and coding conventions.
author | Rik <rik@octave.org> |
---|---|
date | Wed, 30 Nov 2022 20:27:16 -0800 |
parents | 32d2b6604a9f |
children | e88a07dec498 |
comparison
equal
deleted
inserted
replaced
31601:132547cc1ab2 | 31603:23520a50d74d |
---|---|
100 doc: /* -*- texinfo -*- | 100 doc: /* -*- texinfo -*- |
101 @deftypefn {} {} __ftp_cwd__ (@var{handle}, @var{path}) | 101 @deftypefn {} {} __ftp_cwd__ (@var{handle}, @var{path}) |
102 Undocumented internal function | 102 Undocumented internal function |
103 @end deftypefn */) | 103 @end deftypefn */) |
104 { | 104 { |
105 int nargin = args.length (); | |
106 | |
107 std::string path = ""; | 105 std::string path = ""; |
108 if (nargin > 1) | 106 if (args.length () > 1) |
109 path = args(1).xstring_value ("__ftp_cwd__: PATH must be a string"); | 107 path = args(1).xstring_value ("__ftp_cwd__: PATH must be a string"); |
110 | 108 |
111 url_handle_manager& uhm = interp.get_url_handle_manager (); | 109 url_handle_manager& uhm = interp.get_url_handle_manager (); |
112 | 110 |
113 url_transfer url_xfer = uhm.get_object (args(0)); | 111 url_transfer url_xfer = uhm.get_object (args(0)); |
413 @deftypefn {} {} __ftp_mget__ (@var{handle}, @var{pattern}) | 411 @deftypefn {} {} __ftp_mget__ (@var{handle}, @var{pattern}) |
414 @deftypefnx {} {} __ftp_mget__ (@var{handle}, @var{pattern}, @var{target}) | 412 @deftypefnx {} {} __ftp_mget__ (@var{handle}, @var{pattern}, @var{target}) |
415 Undocumented internal function | 413 Undocumented internal function |
416 @end deftypefn */) | 414 @end deftypefn */) |
417 { | 415 { |
418 int nargin = args.length (); | |
419 | |
420 std::string file = args(1).xstring_value ("__ftp_mget__: PATTERN must be a string"); | 416 std::string file = args(1).xstring_value ("__ftp_mget__: PATTERN must be a string"); |
421 | 417 |
422 std::string target; | 418 std::string target; |
423 | 419 |
424 if (nargin == 3 && ! args(2).isempty ()) | 420 if (args.length () == 3 && ! args(2).isempty ()) |
425 target = args(2).xstring_value ("__ftp_mget__: TARGET must be a string") | 421 target = args(2).xstring_value ("__ftp_mget__: TARGET must be a string") |
426 + sys::file_ops::dir_sep_str (); | 422 + sys::file_ops::dir_sep_str (); |
427 | 423 |
428 url_handle_manager& uhm = interp.get_url_handle_manager (); | 424 url_handle_manager& uhm = interp.get_url_handle_manager (); |
429 | 425 |