comparison scripts/audio/@audiorecorder/subsref.m @ 30569:2d6e60776588

Overhaul @audiorecorder class. Eliminate unnecessary input validation that one argument is supplied to class methods as interpreter guarantees the first argument is an @audiorecorder object. Accept case-insensitive property names for get()/set() functions. Add BIST tests on a per function basis rather than only in @audiorecorder constructor. * @audiorecorder/__get_properties__.m: Eliminate nargin checking. Use intermediate variable hrecorder to clarify code. Use ifelse() to simplify 5-line if/else/endif tree. * @audiorecorder/audiorecorder.m: Add input validation to prevent use of callback functions (not currently supported). Add FIXME note and comment out rudimentary support for callback functions. Remove tests of @audiorecorder functionality to the methods files. Add input validation BIST tests for callback function validation. * @audiorecorder/disp.m: Eliminate nargin checking. Mark file as tested for BIST. * @audiorecorder/get.m: Rename "retval" to "value" in function prototype. Use input parameters with names matching documentation rather than varargin. Use new function getproperty() to do actual property retrieval rather than getfield(). Add BIST tests. * @audiorecorder/get.m (getproperty): New function. Function checks property names without regard to case sensitivity and also issues a meaningful error message if the property name does not exist. * @audiorecorder/getaudiodata.m: Eliminate nargin checking. Use intermediate variable hrecorder to clarify code. Use input parameters with names matching documentation rather than varargin. Add case statements for "double" and "single" to support these datatypes. Add input validation for DATATYPE input. Use transpose rather than Hermitian conjugate on data which is never complex. Add BIST tests. * @audiorecorder/getplayer.m: Eliminate nargin checking. Use input parameters with names matching documentation rather than varargin. Add BIST tests, but commented out for now. * @audiorecorder/isrecording.m: Eliminate nargin checking. Add BIST tests. * @audiorecorder/pause.m: Eliminate nargin checking. Mark file as tested for BIST. * @audiorecorder/play.m: Eliminate nargin checking. Use input parameters with names matching documentation rather than varargin. Mark file as tested for BIST. * @audiorecorder/record.m: Eliminate nargin checking. Use input parameters with names matching documentation rather than varargin. Use intermediate variable hrecorder to clarify code. Mark file as tested for BIST. * @audiorecorder/recordblocking.m: Use input parameters with names matching documentation rather than varargin. Mark file as tested for BIST. * @audiorecorder/resume.m: Eliminate nargin checking. Mark file as tested for BIST. * @audiorecorder/set.m: Eliminate nargin checking of first argument. Use input parameter "recorder" for first argument rather than varargin. Use intermediate variable hrecorder to clarify code. Add BIST tests. * @audiorecorder/set.m (setproperty): Use lower() to implement case insensitive matching of property names. Rewrite error() message to be clearer and report the incorrect name. * @audiorecorder/stop.m: Eliminate nargin checking. Mark file as tested for BIST. * @audiorecorder/subsasgn.m: Change output variable name to "recorder" for clarity. Add BIST tests. * @audiorecorder/subsref.m: Add BIST tests.
author Rik <rik@octave.org>
date Thu, 30 Dec 2021 11:20:10 -0800
parents 82b685157e2b
children 597f3ee61a48
comparison
equal deleted inserted replaced
30568:82b685157e2b 30569:2d6e60776588
47 else 47 else
48 error ("@audiorecorder/subsref: invalid subscript type"); 48 error ("@audiorecorder/subsref: invalid subscript type");
49 endif 49 endif
50 50
51 endfunction 51 endfunction
52
53
54 %!testif HAVE_PORTAUDIO; audiodevinfo (1) > 0
55 %! recorder = audiorecorder (44100, 16, 2);
56 %! set (recorder, "Tag", "mytag");
57 %! assert (recorder.Tag, "mytag");
58
59 ## Test input validation
60 %!testif HAVE_PORTAUDIO; audiodevinfo (1) > 0
61 %! recorder = audiorecorder (44100, 16, 2);
62 %! fail ("recorder(1).Tag", "invalid subscript type");
63 %! fail ("recorder{1}.Tag", "invalid subscript type");