comparison libinterp/corefcn/graphics-toolkit.cc @ 31105:670a0d878af1

eliminate WHO arguments from interpreter-private functions * interpreter-private.h, inpterpreter-private.cc (__get_interpreter__, __get_dynamic_loader__, __get_error_system__, __get_gh_manager__, __get_help_system__, __get_input_system__, __get_load_path__, __get_load_save_system__, __get_event_manager__, __get_output_system__, __get_type_info__, __get_symbol_table__, __get_current_scope__, __require_current_scope__, __get_evaluator__, __get_bp_table__, __get_child_list__, __get_cdef_manager__, __get_display_info__, __get_gtk_manager__): Eliminate WHO argument. Previously, it was never displayed by __get_interpreter__. And, as pointed out by Petter Tomner in patch #10216, passing a std::string object could have performance issues. (__get_interpreter__): Eliminate useless call to error. Display message to std::cerr then abort.
author John W. Eaton <jwe@octave.org>
date Wed, 22 Jun 2022 12:48:59 -0400
parents 796f54d4ddbf
children e88a07dec498
comparison
equal deleted inserted replaced
31104:90549b20fb28 31105:670a0d878af1
34 namespace octave 34 namespace octave
35 { 35 {
36 void 36 void
37 base_graphics_toolkit::update (const graphics_handle& h, int id) 37 base_graphics_toolkit::update (const graphics_handle& h, int id)
38 { 38 {
39 gh_manager& gh_mgr = __get_gh_manager__ ("base_graphics_toolkit::update"); 39 gh_manager& gh_mgr = __get_gh_manager__ ();
40 40
41 graphics_object go = gh_mgr.get_object (h); 41 graphics_object go = gh_mgr.get_object (h);
42 42
43 update (go, id); 43 update (go, id);
44 } 44 }
45 45
46 bool 46 bool
47 base_graphics_toolkit::initialize (const graphics_handle& h) 47 base_graphics_toolkit::initialize (const graphics_handle& h)
48 { 48 {
49 gh_manager& gh_mgr 49 gh_manager& gh_mgr = __get_gh_manager__ ();
50 = __get_gh_manager__ ("base_graphics_toolkit::initialize");
51 50
52 graphics_object go = gh_mgr.get_object (h); 51 graphics_object go = gh_mgr.get_object (h);
53 52
54 return initialize (go); 53 return initialize (go);
55 } 54 }
56 55
57 void 56 void
58 base_graphics_toolkit::finalize (const graphics_handle& h) 57 base_graphics_toolkit::finalize (const graphics_handle& h)
59 { 58 {
60 gh_manager& gh_mgr 59 gh_manager& gh_mgr = __get_gh_manager__ ();
61 = __get_gh_manager__ ("base_graphics_toolkit::finalize");
62 60
63 graphics_object go = gh_mgr.get_object (h); 61 graphics_object go = gh_mgr.get_object (h);
64 62
65 finalize (go); 63 finalize (go);
66 } 64 }