comparison scripts/audio/@audioplayer/subsasgn.m @ 30572:6d96538052b9

Overhaul @audioplayer class. Eliminate unnecessary input validation that one argument is supplied to class methods as interpreter guarantees the first argument is an @audioplayer object. Accept case-insensitive property names for get()/set() functions. Add BIST tests on a per function basis rather than only in @audioplayer constructor. * @audioplayer/__get_properties__.m: Eliminate nargin checking. Use intermediate variable hplayer to clarify code. Use ifelse() to simplify 5-line if/else/endif tree. * @audioplayer/audioplayer.m: Add input validation to prevent use of callback functions (not currently supported). Add FIXME note and comment out rudimentary support for callback functions. Remove tests of @audioplayer functionality to the methods files. Add input validation BIST tests for callback function validation. * @audioplayer/disp.m: Eliminate nargin checking. Mark file as tested for BIST. * @audioplayer/get.m: Rename "retval" to "value" in function prototype. Use input parameters with names matching documentation rather than varargin. Use new function getproperty() to do actual property retrieval rather than getfield(). Add BIST tests. * @audioplayer/get.m (getproperty): New function. Function checks property names without regard to case sensitivity and also issues a meaningful error message if the property name does not exist. * @audioplayer/isplaying.m: Eliminate nargin checking. Add BIST tests. * @audioplayer/pause.m: Eliminate nargin checking. Mark file as tested for BIST. * @audioplayer/play.m: Eliminate nargin checking. Use input parameters with names matching documentation rather than varargin. Use intermediate variable hplayer to clarify code. Mark file as tested for BIST. * @audioplayer/playblocking.m: Use input parameters with names matching documentation rather than varargin. Mark file as tested for BIST. * @audioplayer/resume.m: Eliminate nargin checking. Mark file as tested for BIST. * @audioplayer/set.m: Eliminate nargin checking of first argument. Use input parameter "player" for first argument rather than varargin. Use intermediate variable hplayer to clarify code. Add BIST tests. * @audioplayer/set.m (setproperty): Use lower() to implement case insensitive matching of property names. Rewrite error() message to be clearer and report the incorrect name. * @audioplayer/stop.m: Eliminate nargin checking. Mark file as tested for BIST. * @audioplayer/subsasgn.m: Change output variable name to "player" for clarity. Add BIST tests. * @audioplayer/subsref.m: Add BIST tests.
author Rik <rik@octave.org>
date Thu, 30 Dec 2021 16:11:55 -0800
parents 82b685157e2b
children 597f3ee61a48
comparison
equal deleted inserted replaced
30571:faf96757915a 30572:6d96538052b9
31 ## @seealso{@audioplayer/audioplayer} 31 ## @seealso{@audioplayer/audioplayer}
32 ## @end deftypefn 32 ## @end deftypefn
33 33
34 function value = subsasgn (player, idx, rhs) 34 function value = subsasgn (player, idx, rhs)
35 35
36 if (nargin != 3)
37 print_usage ();
38 endif
39
36 if (isempty (idx)) 40 if (isempty (idx))
37 error ("audioplayer: missing index"); 41 error ("audioplayer: missing index");
38 endif 42 endif
39 43
40 if (strcmp (idx(1).type, ".")) 44 if (strcmp (idx(1).type, "."))
44 else 48 else
45 error ("@audioplayer/subsasgn: invalid subscript type"); 49 error ("@audioplayer/subsasgn: invalid subscript type");
46 endif 50 endif
47 51
48 endfunction 52 endfunction
53
54
55 %!testif HAVE_PORTAUDIO; audiodevinfo (0) > 0
56 %! player = audioplayer ([-1, 1], 44100, 8);
57 %! player.Tag = "mytag";
58 %! assert (get (player, "Tag"), "mytag");
59
60 ## Test input validation
61 %!testif HAVE_PORTAUDIO; audiodevinfo (0) > 0
62 %! player = audioplayer ([-1, 1], 44100, 8);
63 %! fail ("player(1).Tag = 5", "invalid subscript type");
64 %! fail ("player{1}.Tag = 5", "invalid subscript type");