Mercurial > octave
comparison liboctave/numeric/sparse-base-chol.cc @ 21136:7cac4e7458f2
maint: clean up code around calls to current_liboctave_error_handler.
Remove statements after call to handler that are no longer reachable.
Place input validation first and immediately call handler if necessary.
Change if/error_handler/else to if/error_handler and re-indent code.
* Array-util.cc, Array.cc, CColVector.cc, CDiagMatrix.cc, CMatrix.cc,
CNDArray.cc, CRowVector.cc, CSparse.cc, DiagArray2.cc, MArray.cc,
PermMatrix.cc, Sparse.cc, Sparse.h, chMatrix.cc, chNDArray.cc, dColVector.cc,
dDiagMatrix.cc, dMatrix.cc, dNDArray.cc, dRowVector.cc, dSparse.cc,
fCColVector.cc, fCDiagMatrix.cc, fCMatrix.cc, fCNDArray.cc, fCRowVector.cc,
fColVector.cc, fDiagMatrix.cc, fMatrix.cc, fNDArray.cc, fRowVector.cc,
idx-vector.cc, CmplxAEPBAL.cc, CmplxCHOL.cc, CmplxGEPBAL.cc, CmplxHESS.cc,
CmplxLU.cc, CmplxQR.cc, CmplxSCHUR.cc, CmplxSVD.cc, DASPK.cc, EIG.cc, LSODE.cc,
Quad.cc, SparseCmplxCHOL.cc, SparseCmplxLU.cc, SparseCmplxQR.cc, SparseQR.cc,
SparsedbleCHOL.cc, SparsedbleLU.cc, base-lu.cc, bsxfun-defs.cc, dbleAEPBAL.cc,
dbleCHOL.cc, dbleGEPBAL.cc, dbleHESS.cc, dbleLU.cc, dbleQR.cc, dbleSCHUR.cc,
dbleSVD.cc, eigs-base.cc, fCmplxAEPBAL.cc, fCmplxCHOL.cc, fCmplxLU.cc,
fCmplxQR.cc, fCmplxSCHUR.cc, fEIG.cc, floatAEPBAL.cc, floatCHOL.cc,
floatGEPBAL.cc, floatHESS.cc, floatLU.cc, floatQR.cc, floatSCHUR.cc,
floatSVD.cc, lo-specfun.cc, oct-fftw.cc, oct-rand.cc, oct-spparms.cc,
sparse-base-chol.cc, sparse-dmsolve.cc, file-ops.cc, lo-sysdep.cc,
mach-info.cc, oct-env.cc, oct-syscalls.cc, cmd-edit.cc, cmd-hist.cc,
data-conv.cc, lo-ieee.cc, lo-regexp.cc, oct-base64.cc, oct-shlib.cc,
pathsearch.cc, singleton-cleanup.cc, sparse-util.cc, unwind-prot.cc:
Remove statements after call to handler that are no longer reachable.
Place input validation first and immediately call handler if necessary.
Change if/error_handler/else to if/error_handler and re-indent code.
| author | Rik <rik@octave.org> |
|---|---|
| date | Sat, 23 Jan 2016 13:52:03 -0800 |
| parents | f5b17eb2508b |
| children | 538b57866b90 |
comparison
equal
deleted
inserted
replaced
| 21135:95da3bc8a281 | 21136:7cac4e7458f2 |
|---|---|
| 87 #ifdef HAVE_CHOLMOD | 87 #ifdef HAVE_CHOLMOD |
| 88 octave_idx_type a_nr = a.rows (); | 88 octave_idx_type a_nr = a.rows (); |
| 89 octave_idx_type a_nc = a.cols (); | 89 octave_idx_type a_nc = a.cols (); |
| 90 | 90 |
| 91 if (a_nr != a_nc) | 91 if (a_nr != a_nc) |
| 92 { | 92 (*current_liboctave_error_handler) ("SparseCHOL requires square matrix"); |
| 93 (*current_liboctave_error_handler) | |
| 94 ("SparseCHOL requires square matrix"); | |
| 95 return -1; | |
| 96 } | |
| 97 | 93 |
| 98 cholmod_common *cm = &Common; | 94 cholmod_common *cm = &Common; |
| 99 | 95 |
| 100 // Setup initial parameters | 96 // Setup initial parameters |
| 101 CHOLMOD_NAME(start) (cm); | 97 CHOLMOD_NAME(start) (cm); |