Mercurial > octave

comparison libgui/src/octave-dock-widget.h @ 31619:ad014fc78bd6

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
use individual local gui_settings objects Previously, we created a single gui_settings object (derived from QSettings) and accessed it from the resource_manager object. That design is not necessary and is not the way QSettings was designed to be used. Instead of managing a single object, we should be using individual QSettings objects where needed. Each individual QSettings object manages thread-safe access to a single global collection of settings. The Qt docs say that operations on QSettings are not thread safe, but that means that you can't create a QSettings object in one thread and use it in another without some locking. I'm not sure whether we were doing that correctly, but with this change it no longer matters. Each QSettings object does perform locking when reading or writing the underlying global data. * resource-manager.h, resource-manager.cc (resource_manager::m_settings): Delete data member. (resource_manager::get_settings): Delete. * annotation-dialog.cc, QTerminal.cc, QTerminal.h, command-widget.cc, command-widget.h, community-news.cc, dialog.cc, documentation-bookmarks.cc, documentation-bookmarks.h, documentation-dock-widget.cc, documentation-dock-widget.h, documentation.cc, documentation.h, dw-main-window.cc, dw-main-window.h, external-editor-interface.cc, files-dock-widget.cc, files-dock-widget.h, find-files-dialog.cc, history-dock-widget.cc, history-dock-widget.h, file-editor-interface.h, file-editor-tab.cc, file-editor-tab.h, file-editor.cc, file-editor.h, find-dialog.cc, octave-qscintilla.cc, main-window.cc, main-window.h, news-reader.cc, octave-dock-widget.cc, octave-dock-widget.h, qt-interpreter-events.cc, qt-interpreter-events.h, release-notes.cc, resource-manager.cc, resource-manager.h, set-path-dialog.cc, settings-dialog.cc, settings-dialog.h, shortcut-manager.cc, shortcut-manager.h, terminal-dock-widget.cc, terminal-dock-widget.h, variable-editor.cc, variable-editor.h, welcome-wizard.cc, workspace-model.cc, workspace-model.h, workspace-view.cc: Use local gui_settings objects instead of accessing a pointer to a single gui_settings object owned by the resource_manager object.
author John W. Eaton <jwe@octave.org>
date Fri, 02 Dec 2022 14:23:53 -0500
parents ef8b02fc4588
children 431f80aba37a
comparison
equal deleted inserted replaced
31618:cd833a9baaa7 31619:ad014fc78bd6
29 #include <QDockWidget> 29 #include <QDockWidget>
30 #include <QIcon> 30 #include <QIcon>
31 #include <QMouseEvent> 31 #include <QMouseEvent>
32 #include <QToolButton> 32 #include <QToolButton>
33 33
34 #include "gui-settings.h"
35 #include "qt-interpreter-events.h" 34 #include "qt-interpreter-events.h"
36 35
37 namespace octave 36 namespace octave
38 { 37 {
39 class base_qobject; 38 class base_qobject;
124 123
125 virtual void activate (void); 124 virtual void activate (void);
126 125
127 virtual void handle_visibility (bool visible); 126 virtual void handle_visibility (bool visible);
128 127
129 virtual void notice_settings (const gui_settings *) { } 128 virtual void notice_settings (void) { }
130 129
131 virtual void save_settings (void); 130 virtual void save_settings (void);
132 131
133 void init_window_menu_entry (void); 132 void init_window_menu_entry (void);
134 133
135 void handle_settings (const gui_settings *); 134 void handle_settings (void);
136 135
137 void handle_active_dock_changed (octave_dock_widget *, octave_dock_widget *); 136 void handle_active_dock_changed (octave_dock_widget *, octave_dock_widget *);
138 137
139 void moveEvent (QMoveEvent *event); 138 void moveEvent (QMoveEvent *event);
140 139