comparison libgui/src/variable-editor.h @ 31619:ad014fc78bd6

use individual local gui_settings objects Previously, we created a single gui_settings object (derived from QSettings) and accessed it from the resource_manager object. That design is not necessary and is not the way QSettings was designed to be used. Instead of managing a single object, we should be using individual QSettings objects where needed. Each individual QSettings object manages thread-safe access to a single global collection of settings. The Qt docs say that operations on QSettings are not thread safe, but that means that you can't create a QSettings object in one thread and use it in another without some locking. I'm not sure whether we were doing that correctly, but with this change it no longer matters. Each QSettings object does perform locking when reading or writing the underlying global data. * resource-manager.h, resource-manager.cc (resource_manager::m_settings): Delete data member. (resource_manager::get_settings): Delete. * annotation-dialog.cc, QTerminal.cc, QTerminal.h, command-widget.cc, command-widget.h, community-news.cc, dialog.cc, documentation-bookmarks.cc, documentation-bookmarks.h, documentation-dock-widget.cc, documentation-dock-widget.h, documentation.cc, documentation.h, dw-main-window.cc, dw-main-window.h, external-editor-interface.cc, files-dock-widget.cc, files-dock-widget.h, find-files-dialog.cc, history-dock-widget.cc, history-dock-widget.h, file-editor-interface.h, file-editor-tab.cc, file-editor-tab.h, file-editor.cc, file-editor.h, find-dialog.cc, octave-qscintilla.cc, main-window.cc, main-window.h, news-reader.cc, octave-dock-widget.cc, octave-dock-widget.h, qt-interpreter-events.cc, qt-interpreter-events.h, release-notes.cc, resource-manager.cc, resource-manager.h, set-path-dialog.cc, settings-dialog.cc, settings-dialog.h, shortcut-manager.cc, shortcut-manager.h, terminal-dock-widget.cc, terminal-dock-widget.h, variable-editor.cc, variable-editor.h, welcome-wizard.cc, workspace-model.cc, workspace-model.h, workspace-view.cc: Use local gui_settings objects instead of accessing a pointer to a single gui_settings object owned by the resource_manager object.
author John W. Eaton <jwe@octave.org>
date Fri, 02 Dec 2022 14:23:53 -0500
parents 796f54d4ddbf
children 431f80aba37a
comparison
equal deleted inserted replaced
31618:cd833a9baaa7 31619:ad014fc78bd6
30 #include <QSignalMapper> 30 #include <QSignalMapper>
31 #include <QStackedWidget> 31 #include <QStackedWidget>
32 #include <QTableView> 32 #include <QTableView>
33 33
34 #include "dw-main-window.h" 34 #include "dw-main-window.h"
35 #include "gui-settings.h"
36 #include "octave-dock-widget.h" 35 #include "octave-dock-widget.h"
37 #include "qt-interpreter-events.h" 36 #include "qt-interpreter-events.h"
38 #include "tab-bar.h" 37 #include "tab-bar.h"
39 38
40 class octave_value; 39 class octave_value;
338 337
339 public slots: 338 public slots:
340 339
341 void callUpdate (const QModelIndex&, const QModelIndex&); 340 void callUpdate (const QModelIndex&, const QModelIndex&);
342 341
343 void notice_settings (const gui_settings *); 342 void notice_settings (void);
344 343
345 void edit_variable (const QString& name, const octave_value& val); 344 void edit_variable (const QString& name, const octave_value& val);
346 345
347 void variable_destroyed (QObject *obj); 346 void variable_destroyed (QObject *obj);
348 347