Mercurial > octave
comparison libinterp/octave-value/ov-base.h @ 31260:c5c8bf50449c
Improve performance of isfield from linear time to constant time (bug #58105)
Patch author: Anonymous in Bug #58105 Comment #7
https://savannah.gnu.org/bugs/index.php?58105#comment7
The isfield function was taking time proportional to the number of
fields in a struct to determine whether something was a member or not.
With this change, isfield performance becomes constant irrespective
of the number of fields, speeding up performance by over 200X, and
also allowing the use of struct as a hashmap if the user desires.
ov-base.h: Add new isfield function declaration
ov-base.cc: Add new isfield function definition
ov-struct.h: Add new isfield function definitions
ov-struct.cc: Do not call map_value
ov.h: Add new isfield function definition
| author | Arun Giridhar <arungiridhar@gmail.com> |
|---|---|
| date | Wed, 05 Oct 2022 10:35:31 -0400 |
| parents | b3ca7f891750 |
| children | e88a07dec498 |
comparison
equal
deleted
inserted
replaced
| 31259:e39634a768e7 | 31260:c5c8bf50449c |
|---|---|
| 667 virtual octave_map map_value (void) const; | 667 virtual octave_map map_value (void) const; |
| 668 | 668 |
| 669 virtual octave_scalar_map scalar_map_value (void) const; | 669 virtual octave_scalar_map scalar_map_value (void) const; |
| 670 | 670 |
| 671 virtual string_vector map_keys (void) const; | 671 virtual string_vector map_keys (void) const; |
| 672 | |
| 673 virtual bool isfield (const std::string&) const; | |
| 672 | 674 |
| 673 virtual std::size_t nparents (void) const; | 675 virtual std::size_t nparents (void) const; |
| 674 | 676 |
| 675 virtual std::list<std::string> parent_class_name_list (void) const; | 677 virtual std::list<std::string> parent_class_name_list (void) const; |
| 676 | 678 |