simplify initialization of gui dock widgets * file-editor.cc (handle_visibility): call common part of this slot instead of repeating its contents here * main-window.cc (main_window): do not connect visibility changed signal from dock widgets since this is done in the dock widget constructors; instead emit new signal for initialization of the window menu and setup editor shortcuts (connect_visibility_changed): removed obsolete method * main-window.h: new signal init_window_menu, removed method connect_visibility_changed * octave-dock-widget.cc (octave_dock_widget): rename slot for visibilityChanged signal, connect new slot for initialization of the window menu (connect_visibility_changed): remove obsolete method; (init_window_menu_entry): new slot for dis/enabling related menu window entry; (handle_visibility): combine contents from former two slots * octave-dock-widget.h: removed slot connect_visibility_changed, new signal init_window_menu_entry, removed slot handle_visibility_changed

--- a/libgui/src/octave-dock-widget.h	Fri Dec 18 16:16:53 2020 -0800
+++ b/libgui/src/octave-dock-widget.h	Sat Dec 19 10:49:43 2020 +0100
@@ -92,8 +92,6 @@
 
     virtual ~octave_dock_widget (void) = default;
 
-    virtual void connect_visibility_changed (void);
-
     void set_predecessor_widget (octave_dock_widget *prev_widget);
 
   signals:
@@ -126,6 +124,8 @@
 
     virtual void notice_settings (const gui_settings *) { }
 
+    void init_window_menu_entry (void);
+
     void handle_settings (const gui_settings *);
 
     void handle_active_dock_changed (octave_dock_widget*, octave_dock_widget*);
@@ -148,14 +148,6 @@
 
     virtual void toplevel_change (bool);
 
-    //! Slot to steer changing visibility from outside.
-
-    virtual void handle_visibility_changed (bool visible)
-    {
-      if (visible)
-        emit active_changed (true);
-    }
-
     //! Event filter for double clicks into the window decoration elements.
 
     bool eventFilter (QObject *obj, QEvent *e);