Mercurial > octave
diff libgui/src/m-editor/file-editor-interface.h @ 29783:5154c91e0d98
eliminate some connections to parent objects in octave_dock_widget classes
This is another change aimed at removing connections to parent
objects and ultimately, to avoid needing to store references to
base_qobject in any widgets.
* octave-dock-widget.h, octave-dock-widget.cc
(octave_dock_widget::interpreter_event): Delete signals.
(octave_dock_widget::octave_dock_widget): Don't connect
interpreter_event signals to base_qobject slots.
* file-editor-interface.h (file_editor_interface::interpreter_event):
Declare signals here.
* variable-editor.h (variable_editor::interpreter_event): Likewise.
* main-window.cc (main_window::main_window): Make interpreter_event
connections for the editor.
* octave-qobject.h, octave-qobject.cc
(base_qobject::connect_interpreter_events): New function.
(base_qobject::variable_editor_widget): Make interpreter_event
connections here.
* QTerminal.h, QTerminal.cc (QTerminal::create, QTerminal::construct):
Eliminate MAIN_WIN argument. Change all callers.
(QTerminal::construct): Don't make connections to main window signals
or slots here.
(QTerminal::request_edit_mfile_signal,
QTerminal::request_open_file_signal,
QTerminal::set_screen_size_signal,
QTerminal::clear_command_window_request): New signals.
* QUnixTerminalImpl.h, QUnixTerminalImpl.cpp
(QUnixTerminalImpl::initialize, QUnixTerminalImpl::QUnixTerminalImpl):
Eliminate MAIN_WIN argument. Change all callers.
(QUnixTerminalImpl::initialize): Don't make connections to main window
signals or slots here.
* QWinTerminalImpl.h, QWinTerminalImpl.cpp
(QWinTerminalImpl::QWinTerminalImpl): Eliminate MAIN_WIN argument.
Change all callers. Don't make connections to main window slot here.
(QWinTerminalImpl::set_screen_size_signal): Delete. Signal moved to
QTerminal base class.
* terminal-dock-widget.h, terminal-dock-widget.cc
(terminal_dock_widget::get_qteriminal,
terminal_dock_widget::get_command_widget): New functions.
(terminal_dock_widget::terminal_dock_widget): Don't make connections
to main window signals or slots here.
* main-window.h, main-window.cc (main_window::main_window): Make
connections from terminal widgets to main window here.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Fri, 18 Jun 2021 15:41:36 -0400 |
parents | 9367cba2a6d5 |
children | d4d83344d653 |
line wrap: on
line diff
--- a/libgui/src/m-editor/file-editor-interface.h Fri Jun 18 01:20:46 2021 -0400 +++ b/libgui/src/m-editor/file-editor-interface.h Fri Jun 18 15:41:36 2021 -0400 @@ -78,6 +78,11 @@ virtual void enable_menu_shortcuts (bool enable) = 0; + signals: + + void interpreter_event (const fcn_callback& fcn); + void interpreter_event (const meth_callback& meth); + public slots: virtual void toplevel_change (bool) = 0;