diff libinterp/corefcn/defun.cc @ 31105:670a0d878af1

eliminate WHO arguments from interpreter-private functions * interpreter-private.h, inpterpreter-private.cc (__get_interpreter__, __get_dynamic_loader__, __get_error_system__, __get_gh_manager__, __get_help_system__, __get_input_system__, __get_load_path__, __get_load_save_system__, __get_event_manager__, __get_output_system__, __get_type_info__, __get_symbol_table__, __get_current_scope__, __require_current_scope__, __get_evaluator__, __get_bp_table__, __get_child_list__, __get_cdef_manager__, __get_display_info__, __get_gtk_manager__): Eliminate WHO argument. Previously, it was never displayed by __get_interpreter__. And, as pointed out by Petter Tomner in patch #10216, passing a std::string object could have performance issues. (__get_interpreter__): Eliminate useless call to error. Display message to std::cerr then abort.
author John W. Eaton <jwe@octave.org>
date Wed, 22 Jun 2022 12:48:59 -0400
parents 796f54d4ddbf
children e88a07dec498
line wrap: on
line diff
--- a/libinterp/corefcn/defun.cc	Tue Jun 21 15:44:03 2022 +0200
+++ b/libinterp/corefcn/defun.cc	Wed Jun 22 12:48:59 2022 -0400
@@ -54,7 +54,7 @@
 void
 print_usage (void)
 {
-  tree_evaluator& tw = __get_evaluator__ ("print_usage");
+  tree_evaluator& tw = __get_evaluator__ ();
 
   const octave_function *cur = tw.current_function ();
 
@@ -97,7 +97,7 @@
 
   octave_value fval (fcn);
 
-  symbol_table& symtab = __get_symbol_table__ ("install_dld_function");
+  symbol_table& symtab = __get_symbol_table__ ();
 
   symtab.install_built_in_function (name, fval);
 }
@@ -114,7 +114,7 @@
 
   octave_value fval (fcn);
 
-  symbol_table& symtab = __get_symbol_table__ ("install_dld_function");
+  symbol_table& symtab = __get_symbol_table__ ();
 
   symtab.install_built_in_function (name, fval);
 }
@@ -130,7 +130,7 @@
 
   octave_value fval (fcn);
 
-  symbol_table& symtab = __get_symbol_table__ ("install_mex_function");
+  symbol_table& symtab = __get_symbol_table__ ();
 
   symtab.install_built_in_function (name, fval);
 }
@@ -140,7 +140,7 @@
 {
   dynamic_library retval;
 
-  tree_evaluator& tw = __get_evaluator__ ("get_current_shlib");
+  tree_evaluator& tw = __get_evaluator__ ();
 
   octave_function *curr_fcn = tw.current_function ();