Mercurial > octave

diff libinterp/corefcn/interpreter-private.h @ 31105:670a0d878af1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
eliminate WHO arguments from interpreter-private functions * interpreter-private.h, inpterpreter-private.cc (__get_interpreter__, __get_dynamic_loader__, __get_error_system__, __get_gh_manager__, __get_help_system__, __get_input_system__, __get_load_path__, __get_load_save_system__, __get_event_manager__, __get_output_system__, __get_type_info__, __get_symbol_table__, __get_current_scope__, __require_current_scope__, __get_evaluator__, __get_bp_table__, __get_child_list__, __get_cdef_manager__, __get_display_info__, __get_gtk_manager__): Eliminate WHO argument. Previously, it was never displayed by __get_interpreter__. And, as pointed out by Petter Tomner in patch #10216, passing a std::string object could have performance issues. (__get_interpreter__): Eliminate useless call to error. Display message to std::cerr then abort.
author John W. Eaton <jwe@octave.org>
date Wed, 22 Jun 2022 12:48:59 -0400
parents 796f54d4ddbf
children e88a07dec498
line wrap: on
line diff
--- a/libinterp/corefcn/interpreter-private.h	Tue Jun 21 15:44:03 2022 +0200
+++ b/libinterp/corefcn/interpreter-private.h	Wed Jun 22 12:48:59 2022 -0400
@@ -53,45 +53,45 @@
   class tree_evaluator;
   class type_info;
 
-  extern OCTINTERP_API interpreter& __get_interpreter__ (const std::string& who);
+  extern OCTINTERP_API interpreter& __get_interpreter__ (void);
 
-  extern OCTINTERP_API dynamic_loader& __get_dynamic_loader__ (const std::string& who);
+  extern OCTINTERP_API dynamic_loader& __get_dynamic_loader__ (void);
 
-  extern OCTINTERP_API error_system& __get_error_system__ (const std::string& who);
+  extern OCTINTERP_API error_system& __get_error_system__ (void);
 
-  extern OCTINTERP_API gh_manager& __get_gh_manager__ (const std::string& who);
+  extern OCTINTERP_API gh_manager& __get_gh_manager__ (void);
 
-  extern OCTINTERP_API help_system& __get_help_system__ (const std::string& who);
+  extern OCTINTERP_API help_system& __get_help_system__ (void);
 
-  extern OCTINTERP_API input_system& __get_input_system__ (const std::string& who);
+  extern OCTINTERP_API input_system& __get_input_system__ (void);
 
-  extern OCTINTERP_API load_path& __get_load_path__ (const std::string& who);
+  extern OCTINTERP_API load_path& __get_load_path__ (void);
 
-  extern OCTINTERP_API load_save_system& __get_load_save_system__ (const std::string& who);
+  extern OCTINTERP_API load_save_system& __get_load_save_system__ (void);
 
-  extern OCTINTERP_API event_manager& __get_event_manager__ (const std::string& who);
+  extern OCTINTERP_API event_manager& __get_event_manager__ (void);
 
-  extern OCTINTERP_API output_system& __get_output_system__ (const std::string& who);
+  extern OCTINTERP_API output_system& __get_output_system__ (void);
 
-  extern OCTINTERP_API type_info& __get_type_info__ (const std::string& who);
+  extern OCTINTERP_API type_info& __get_type_info__ (void);
 
-  extern OCTINTERP_API symbol_table& __get_symbol_table__ (const std::string& who);
+  extern OCTINTERP_API symbol_table& __get_symbol_table__ (void);
 
-  extern OCTINTERP_API symbol_scope __get_current_scope__ (const std::string& who);
+  extern OCTINTERP_API symbol_scope __get_current_scope__ (void);
 
-  extern OCTINTERP_API symbol_scope __require_current_scope__ (const std::string& who);
+  extern OCTINTERP_API symbol_scope __require_current_scope__ (void);
 
-  extern OCTINTERP_API tree_evaluator& __get_evaluator__ (const std::string& who);
+  extern OCTINTERP_API tree_evaluator& __get_evaluator__ (void);
 
-  extern OCTINTERP_API bp_table& __get_bp_table__ (const std::string& who);
+  extern OCTINTERP_API bp_table& __get_bp_table__ (void);
 
-  extern OCTINTERP_API child_list& __get_child_list__ (const std::string& who);
+  extern OCTINTERP_API child_list& __get_child_list__ (void);
 
-  extern OCTINTERP_API cdef_manager& __get_cdef_manager__ (const std::string& who);
+  extern OCTINTERP_API cdef_manager& __get_cdef_manager__ (void);
 
-  extern OCTINTERP_API display_info& __get_display_info__ (const std::string& who);
+  extern OCTINTERP_API display_info& __get_display_info__ (void);
 
-  extern OCTINTERP_API gtk_manager& __get_gtk_manager__ (const std::string& who);
+  extern OCTINTERP_API gtk_manager& __get_gtk_manager__ (void);
 
   // Functions that could be methods in the interpreter class but maybe
   // shouldn't be exposed as part of the public interface.