diff libinterp/corefcn/pager.cc @ 31105:670a0d878af1

eliminate WHO arguments from interpreter-private functions * interpreter-private.h, inpterpreter-private.cc (__get_interpreter__, __get_dynamic_loader__, __get_error_system__, __get_gh_manager__, __get_help_system__, __get_input_system__, __get_load_path__, __get_load_save_system__, __get_event_manager__, __get_output_system__, __get_type_info__, __get_symbol_table__, __get_current_scope__, __require_current_scope__, __get_evaluator__, __get_bp_table__, __get_child_list__, __get_cdef_manager__, __get_display_info__, __get_gtk_manager__): Eliminate WHO argument. Previously, it was never displayed by __get_interpreter__. And, as pointed out by Petter Tomner in patch #10216, passing a std::string object could have performance issues. (__get_interpreter__): Eliminate useless call to error. Display message to std::cerr then abort.
author John W. Eaton <jwe@octave.org>
date Wed, 22 Jun 2022 12:48:59 -0400
parents 32d2b6604a9f
children e88a07dec498
line wrap: on
line diff
--- a/libinterp/corefcn/pager.cc	Tue Jun 21 15:44:03 2022 +0200
+++ b/libinterp/corefcn/pager.cc	Wed Jun 22 12:48:59 2022 -0400
@@ -127,7 +127,7 @@
   int
   pager_buf::sync (void)
   {
-    output_system& output_sys = __get_output_system__ ("pager_buf::sync");
+    output_system& output_sys = __get_output_system__ ();
 
     char *buf = pbase ();
 
@@ -164,7 +164,7 @@
   int
   diary_buf::sync (void)
   {
-    output_system& output_sys = __get_output_system__ ("__stdout__");
+    output_system& output_sys = __get_output_system__ ();
 
     std::ofstream& external_diary_file = output_sys.external_diary_file ();
 
@@ -259,7 +259,7 @@
 
   void flush_stdout (void)
   {
-    output_system& output_sys = __get_output_system__ ("flush_stdout");
+    output_system& output_sys = __get_output_system__ ();
 
     output_sys.flush_stdout ();
   }
@@ -491,14 +491,14 @@
 
   std::ostream& __stdout__ (void)
   {
-    output_system& output_sys = __get_output_system__ ("__stdout__");
+    output_system& output_sys = __get_output_system__ ();
 
     return output_sys.__stdout__ ();
   }
 
   std::ostream& __diary__ (void)
   {
-    output_system& output_sys = __get_output_system__ ("__diary__");
+    output_system& output_sys = __get_output_system__ ();
 
     return output_sys.__diary__ ();
   }