diff libinterp/octave-value/cdef-utils.cc @ 31105:670a0d878af1

eliminate WHO arguments from interpreter-private functions * interpreter-private.h, inpterpreter-private.cc (__get_interpreter__, __get_dynamic_loader__, __get_error_system__, __get_gh_manager__, __get_help_system__, __get_input_system__, __get_load_path__, __get_load_save_system__, __get_event_manager__, __get_output_system__, __get_type_info__, __get_symbol_table__, __get_current_scope__, __require_current_scope__, __get_evaluator__, __get_bp_table__, __get_child_list__, __get_cdef_manager__, __get_display_info__, __get_gtk_manager__): Eliminate WHO argument. Previously, it was never displayed by __get_interpreter__. And, as pointed out by Petter Tomner in patch #10216, passing a std::string object could have performance issues. (__get_interpreter__): Eliminate useless call to error. Display message to std::cerr then abort.
author John W. Eaton <jwe@octave.org>
date Wed, 22 Jun 2022 12:48:59 -0400
parents 83f9f8bda883
children e88a07dec498
line wrap: on
line diff
--- a/libinterp/octave-value/cdef-utils.cc	Tue Jun 21 15:44:03 2022 +0200
+++ b/libinterp/octave-value/cdef-utils.cc	Wed Jun 22 12:48:59 2022 -0400
@@ -80,7 +80,7 @@
   lookup_class (const std::string& name, bool error_if_not_found,
                 bool load_if_not_found)
   {
-    cdef_manager& cdm = __get_cdef_manager__ ("lookup_class");
+    cdef_manager& cdm = __get_cdef_manager__ ();
 
     return cdm.find_class (name, error_if_not_found, load_if_not_found);
   }
@@ -238,7 +238,7 @@
   lookup_package (const std::string& name, bool error_if_not_found,
                   bool load_if_not_found)
   {
-    cdef_manager& cdm = __get_cdef_manager__ ("lookup_package");
+    cdef_manager& cdm = __get_cdef_manager__ ();
 
     return cdm.find_package (name, error_if_not_found, load_if_not_found);
   }
@@ -257,7 +257,7 @@
     // methods will use the dispatch class of the class in which they
     // are defined instead of the class in which they are executing.
 
-    tree_evaluator& tw = __get_evaluator__ ("get_class_context");
+    tree_evaluator& tw = __get_evaluator__ ();
 
     std::string dispatch_class = tw.get_dispatch_class ();