diff libinterp/corefcn/sysdep.cc @ 20799:c349d4c91ce2

eliminate return statements after calls to print_usage * symtab.cc, sysdep.cc, toplev.cc, tsearch.cc, urlwrite.cc, variables.cc: Eliminate return statements after calls to print_usage.
author John W. Eaton <jwe@octave.org>
date Thu, 03 Dec 2015 16:40:05 -0500
parents 4c15057e1bc6
children f428cbe7576f
line wrap: on
line diff
--- a/libinterp/corefcn/sysdep.cc	Thu Dec 03 15:07:01 2015 -0500
+++ b/libinterp/corefcn/sysdep.cc	Thu Dec 03 16:40:05 2015 -0500
@@ -193,27 +193,25 @@
 {
   octave_value retval;
 
-  if (args.length () == 1)
-    {
-      std::string file = args(0).xstring_value ("__open_with_system_app__: argument must be a filename");
+  if (args.length () != 1)
+    print_usage ();
+
+  std::string file = args(0).xstring_value ("__open_with_system_app__: argument must be a filename");
 
 #if defined (__WIN32__) && ! defined (_POSIX_VERSION)
-      HINSTANCE status = ShellExecute (0, 0, file.c_str (), 0, 0,
-                                       SW_SHOWNORMAL);
+  HINSTANCE status = ShellExecute (0, 0, file.c_str (), 0, 0,
+                                   SW_SHOWNORMAL);
 
-      // ShellExecute returns a value greater than 32 if successful.
-      retval = (reinterpret_cast<ptrdiff_t> (status) > 32);
+  // ShellExecute returns a value greater than 32 if successful.
+  retval = (reinterpret_cast<ptrdiff_t> (status) > 32);
 #else
-      octave_value_list tmp
-        = Fsystem (ovl ("xdg-open " + file + " 2> /dev/null",
-                        false, "async"),
-                   1);
+  octave_value_list tmp
+    = Fsystem (ovl ("xdg-open " + file + " 2> /dev/null",
+                    false, "async"),
+               1);
 
-      retval = (tmp(0).double_value () == 0);
+  retval = (tmp(0).double_value () == 0);
 #endif
-    }
-  else
-    print_usage ();
 
   return retval;
 }
@@ -614,20 +612,14 @@
 @seealso{setenv, unsetenv}\n\
 @end deftypefn")
 {
-  octave_value retval;
-
   int nargin = args.length ();
 
-  if (nargin == 1)
-    {
-      std::string name = args(0).string_value ();
-
-      retval = octave_env::getenv (name);
-    }
-  else
+  if (nargin != 1)
     print_usage ();
 
-  return retval;
+  std::string name = args(0).string_value ();
+
+  return octave_value (octave_env::getenv (name));
 }
 
 /*
@@ -650,18 +642,16 @@
 
   int nargin = args.length ();
 
-  if (nargin == 2 || nargin == 1)
-    {
-      std::string var = args(0).xstring_value ("setenv: VAR must be a string");
+  if (nargin < 1 || nargin > 2)
+    print_usage ();
+
+  std::string var = args(0).xstring_value ("setenv: VAR must be a string");
 
-      std::string val = (nargin == 2
-                         ? args(1).xstring_value ("setenv: VALUE must be a string")
-                         : std::string ());
+  std::string val = (nargin == 2
+                     ? args(1).xstring_value ("setenv: VALUE must be a string")
+                     : std::string ());
 
-      octave_env::putenv (var, val);
-    }
-  else
-    print_usage ();
+  octave_env::putenv (var, val);
 
   return retval;
 }
@@ -686,20 +676,14 @@
 @seealso{setenv, getenv}\n\
 @end deftypefn")
 {
-  octave_value retval;
-
   int nargin = args.length ();
 
-  if (nargin == 1)
-    {
-      std::string tmp = args(0).string_value ();
-
-      retval = gnulib::unsetenv (tmp.c_str ());
-    }
-  else
+  if (nargin != 1)
     print_usage ();
 
-  return retval;
+  std::string tmp = args(0).string_value ();
+
+  return octave_value (gnulib::unsetenv (tmp.c_str ()));
 }
 
 /*
@@ -785,11 +769,8 @@
 
   int nargin = args.length ();
 
-  if (! (nargin == 0 || nargin == 1))
-    {
-      print_usage ();
-      return retval;
-    }
+  if (nargin > 1)
+    print_usage ();
 
   if (nargin == 1)
     {
@@ -836,20 +817,18 @@
 {
   octave_value_list retval;
 
-  if (args.length () == 1)
-    {
-      double dval = args(0).double_value ();
+  if (args.length () != 1)
+    print_usage ();
+
+  double dval = args(0).double_value ();
 
-      if (xisnan (dval))
-        warning ("sleep: NaN is an invalid delay");
-      else
-        {
-          Fdrawnow ();
-          octave_sleep (dval);
-        }
+  if (xisnan (dval))
+    warning ("sleep: NaN is an invalid delay");
+  else
+    {
+      Fdrawnow ();
+      octave_sleep (dval);
     }
-  else
-    print_usage ();
 
   return retval;
 }
@@ -876,24 +855,22 @@
 {
   octave_value_list retval;
 
-  if (args.length () == 1)
-    {
-      double dval = args(0).double_value ();
+  if (args.length () != 1)
+    print_usage ();
+
+  double dval = args(0).double_value ();
 
-      if (xisnan (dval))
-        warning ("usleep: NaN is an invalid delay");
-      else
-        {
-          Fdrawnow ();
+  if (xisnan (dval))
+    warning ("usleep: NaN is an invalid delay");
+  else
+    {
+      Fdrawnow ();
 
-          int delay = NINT (dval);
+      int delay = NINT (dval);
 
-          if (delay > 0)
-            octave_usleep (delay);
-        }
+      if (delay > 0)
+        octave_usleep (delay);
     }
-  else
-    print_usage ();
 
   return retval;
 }
@@ -975,21 +952,19 @@
 
   int nargin = args.length ();
 
-  if (nargin == 1)
-    {
-      octave_value arg = args(0);
+  if (nargin != 1)
+    print_usage ();
 
-      string_vector sv = arg.xall_strings ("tilde_expand: argument must be char or cellstr object");
+  octave_value arg = args(0);
 
-      sv = file_ops::tilde_expand (sv);
+  string_vector sv = arg.xall_strings ("tilde_expand: argument must be char or cellstr object");
 
-      if (arg.is_cellstr ())
-        retval = Cell (arg.dims (), sv);
-      else
-        retval = sv;
-    }
+  sv = file_ops::tilde_expand (sv);
+
+  if (arg.is_cellstr ())
+    retval = Cell (arg.dims (), sv);
   else
-    print_usage ();
+    retval = sv;
 
   return retval;
 }