Remove inconsistent warning "Octave:divide-by-zero" (bug #46650). * libinterp/corefcn/errwarn.h (warn_divide_by_zero), libinterp/corefcn/errwarn.cc (warn_divide_by_zero): Deprecate function "warn_divide_by_zero", and leave implementation empty for a few releases. * libinterp/corefcn/error.cc: Use different id for test. * examples/code/make_int.cc: No longer advertise "warn_divide_by_zero" in the examples. * libinterp/operators/op-*-*.cc: Remove unused header "errwarn.h". Remove check for scalar zero divisor including the warning. * libinterp/operators/op-dms-template.cc (gripe_if_zero): Remove function. * scripts/general/quadgk.m, scripts/general/quadv.m, scripts/statistics/kurtosis.m, scripts/statistics/mean.m, scripts/statistics/skewness.m: No longer need to turn off unused warning. * scripts/help/warning_ids.m: Remove documentation of "Octave:divide-by-zero". * test/jit.tst, test/mk-sparse-tst.sh, test/prefer.tst: Remove warning "Octave:divide-by-zero".

--- a/libinterp/corefcn/error.cc	Tue Jan 22 08:07:55 2019 -0500
+++ b/libinterp/corefcn/error.cc	Tue Jan 22 14:34:08 2019 +0100
@@ -993,7 +993,7 @@
           else if (arg.is_string ())
             {
               tmpstr = arg.string_value ();  // 2-stage assignment required
-              msg = tmpstr.c_str ();         // in order to generate pointer  
+              msg = tmpstr.c_str ();         // in order to generate pointer
                                              // to valid memory.
             }
         }
@@ -1819,7 +1819,7 @@
 
 /*
 %!test <*51997>
-%! id = "Octave:divide-by-zero";
+%! id = "Octave:logical-conversion";
 %! current = warning ("query", id);
 %! current_all = warning ();
 %! previous = warning (current_all);