Mercurial > octave

diff libgui/src/welcome-wizard.cc @ 27613:deb8877f2c34

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
use symbolic constants for preferences key and default values in news reader * gui-preferences-all.h: added new include file for news reader * main-window.cc: include new include file for news reader (main_window, load_and_display_community_news): use symbolic constants for news reader preferences * module.mk: added new include file for news reader * news-reader.cc: include new include file for news reader (process): use symbolic constants for news reader preferences * settings-dialog.cc (settings_dialog, write_changed_settings): use symbolic constants for news reader preferences * welcome-wizard.cc (handle_web_connect_option): use symbolic constants for news reader preferences; (setup_community_news): use default value for presetting the checkbox for internet connection
author Torsten Lilge <ttl-octave@mailbox.org>
date Sat, 02 Nov 2019 07:41:42 +0100
parents 0495b64288f7
children 45bb5bbaf291
line wrap: on
line diff
--- a/libgui/src/welcome-wizard.cc	Fri Nov 01 18:29:47 2019 -0400
+++ b/libgui/src/welcome-wizard.cc	Sat Nov 02 07:41:42 2019 +0100
@@ -38,6 +38,7 @@
 
 #include "resource-manager.h"
 #include "welcome-wizard.h"
+#include "gui-preferences-nr.h"
 
 namespace octave
 {
@@ -145,7 +146,7 @@
 
     if (settings)
       {
-        settings->setValue ("news/allow_web_connection",
+        settings->setValue (nr_allow_connection.key,
                             m_allow_web_connect_state);
 
         settings->sync ();
@@ -249,9 +250,11 @@
 
     QHBoxLayout *checkbox_layout = new QHBoxLayout;
 
-    // FIXME: Synchronize the initial state of this checkbox with the default
-    // value of "news/allow_web_connection" stored elsewhere.
-    m_checkbox->setCheckState (Qt::Unchecked);
+    bool allow_connection = nr_allow_connection.def.toBool ();
+    if (allow_connection)
+      m_checkbox->setCheckState (Qt::Checked);
+    else
+      m_checkbox->setCheckState (Qt::Unchecked);
 
     m_checkbox_message->setText
       (tr ("<html><head>\n"