Mercurial > octave
diff libgui/src/history-dockwidget.h @ 16447:e3b33a7530bc
improve encapsulation of history window object
* history-dockwidget.h, history-dockwidget.cc
(history_dock_widget::history_dock_widget): Set status tip here.
Connect history_dock_widget::information signal to
main_window::report_status_message.
Connect history_dock_widget::command_double_clicked signal to
main_window::handle_command_double_clicked.
(history_dock_widget::connect_visibility_changed,
history_dock_widget::focus, history_dock_widget::handle_visibility):
New functions.
* main-window.h, main-window.cc (main_window::history_window): Rename
from _history_dock_widget. Don't use a pointer. Change all uses.
(main_window::main_window): Initialize it here.
(main_window::~main_window): Don't delete _history_dock_widget.
(main_window::focus_history_window_signal): New signal.
(main_window::focus_history_window): Rename from
main_window::focus_command_history. Emit focus_history_window_signal
instead of performing actions here.
(main_window::handle_command_history_visible): Delete.
(main_window::connect_visibility_changed): Call
history_window.connect_visibility_changed instead of performing
actions here.
(main_window::construct): Don't create _history_dock_widget. Adapt
signal/slot connections for new history_window object.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Sat, 06 Apr 2013 16:46:14 -0400 |
parents | 5982d469f79b |
children | 744ff2fe11ce |
line wrap: on
line diff
--- a/libgui/src/history-dockwidget.h Sat Apr 06 16:14:32 2013 -0400 +++ b/libgui/src/history-dockwidget.h Sat Apr 06 16:46:14 2013 -0400 @@ -32,27 +32,38 @@ class history_dock_widget : public octave_dock_widget { Q_OBJECT - public: + +public: + history_dock_widget (QWidget *parent = 0); + void connect_visibility_changed (void); + public slots: + void set_history (const QStringList& hist); void append_history (const QString& hist_entry); void clear_history (void); + void focus (void); + void handle_visibility (bool); + signals: + void information (const QString& message); /** Emitted, whenever the user double-clicked a command in the history. */ void command_double_clicked (const QString& command); private slots: + void handle_double_click (QModelIndex modelIndex); void handle_contextmenu_copy(bool flag); void handle_contextmenu_evaluate(bool flag); void ctxMenu(const QPoint &pos); private: + void construct (); QListView *_history_list_view; QLineEdit *_filter_line_edit;