view test/deprecate-props.tst @ 23210:3a298e07002c

Deprecate "light" and "demi" values for "fontweight" property (bug #50353). * NEWS: announce deprecation. * graphics.in.h (text::properties::update_fontweight uicontrol::properties::update_fontweight): emit a warning when value is "demi" or "light". * graphics.in.h (uipanel::properties::update_fontweight uibuttongroup::properties::update_fontweight): new updater, emit a warning when value is "demi" or "light". * genpropdoc.m: provide templates for font* properties doc. Remove "demi" and "light" from fontweight docstrings. * deprecate-prop.tst: add test for deprecated values and instructions on how to remove them in 4.7+. * QtHandlesUtils.cc (computeFont): fix typo in "bold" case.
author Pantxo Diribarne <pantxo.diribarne@gmail.com>
date Sun, 19 Feb 2017 12:37:59 +0100
parents 239a9fed80de
children 194eb4bd202b
line wrap: on
line source

## Copyright (C) 2017 Pantxo Diribarne
##
## This file is part of Octave.
##
## Octave is free software; you can redistribute it and/or modify it
## under the terms of the GNU General Public License as published by
## the Free Software Foundation; either version 3 of the License, or
## (at your option) any later version.
##
## Octave is distributed in the hope that it will be useful, but
## WITHOUT ANY WARRANTY; without even the implied warranty of
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
## GNU General Public License for more details.
##
## You should have received a copy of the GNU General Public License
## along with Octave; see the file COPYING.  If not, see
## <http://www.gnu.org/licenses/>.

## Put graphics properties here that should be removed, or for which some
## values (radio strings only) should not be accepted, in a given future
## version.  Don't forget to add a note in the NEWS file.

%!function testprop (h, prop, vrs, val = [])
%!  vrsmax = strsplit (vrs, ".");
%!  vrscur = strsplit (version (), ".");
%!  if (num2str (vrsmax{1}) < num2str (vrscur{1}) ||
%!      num2str (vrsmax{2}) < num2str (vrscur{2}))
%!    if (isempty (val) && isprop (h, prop))
%!      error ("Please remove %s property %s", get (h, "type"), prop);
%!    elseif (! isempty (val) && ! isempty (strfind (val, set (h, prop))))
%!      error ("Please remove '%s' from allowed values for %s property %s",
%!             val, get (h, "type"), prop);
%!    endif
%!  endif
%!endfunction

## patch/surface "normalmode" deprecated in 4.2, remove from 4.5.+
%!test
%! hf = figure ("visible", "off");
%! unwind_protect
%!   hp = patch ();
%!   testprop (hp, "normalmode", "4.4");
%! unwind_protect_cleanup
%!   close (hf);
%! end_unwind_protect

%! hf = figure ("visible", "off");
%! unwind_protect
%!   hs = surface ();
%!   testprop (hs, "normalmode", "4.4");
%! unwind_protect_cleanup
%!   close (hf);
%! end_unwind_protect

## axes, "zero" value for "x/yaxislocation" deprecated in 4.2, remove from 4.5.+
%!test
%! hf = figure ("visible", "off");
%! unwind_protect
%!   ha = axes ();
%!   testprop (ha, "xaxislocation", "4.4", "zero");
%!   testprop (ha, "yaxislocation", "4.4", "zero");
%! unwind_protect_cleanup
%!   close (hf);
%! end_unwind_protect

## annotation rectangle "edgecolor" deprecated in 4.4, remove from 4.7.+
%!test
%! hf = figure ("visible", "off");
%! unwind_protect
%!   ha = annotation ("rectangle");
%!   testprop (ha, "edgecolor", "4.6");
%! unwind_protect_cleanup
%!   close (hf);
%! end_unwind_protect

## figure "doublebuffer, mincolormap, wvisual, wvisualmode, xdisplay,
## xvisual, xvisualmode" deprecated in 4.4, remove from 4.7.+
%!test
%! hf = figure ("visible", "off");
%! unwind_protect
%!   testprop (hf, "doublebuffer", "4.6");
%!   testprop (hf, "mincolormap", "4.6");
%!   testprop (hf, "wvisual", "4.6");
%!   testprop (hf, "wvisualmode", "4.6");
%!   testprop (hf, "xdisplay", "4.6");
%!   testprop (hf, "xvisual", "4.6");
%!   testprop (hf, "xvisualmode", "4.6");
%! unwind_protect_cleanup
%!   close (hf)
%! end_unwind_protect

## axes "drawmode" deprecated in 4.4, remove from 4.7.+
%!test
%! hf = figure ("visible", "off");
%! unwind_protect
%!   hax = axes ();
%!   testprop (hax, "drawmode", "4.6");
%! unwind_protect_cleanup
%!   close (hf);
%! end_unwind_protect

## text/uicontrol/uipanel/uibuttongroup  "demi" and "light" values for
## "fontweight" property are deprecated in 4.4, remove from 4.7.+:
##   * remove "demi" and "light" options in graphics.in.h,
##   QtHandlesUtils.cc and ft-text-renderer.cc
##   * remove warnings from update_fontweight in graphics.in.h
%!test
%! hf = figure ("visible", "off");
%! unwind_protect
%!   ht = text ();
%!   testprop (ht, "fontweight", "4.6", "demi");
%!   testprop (ht, "fontweight", "4.6", "light");
%!   hui = uicontrol ();
%!   testprop (hui, "fontweight", "4.6", "demi");
%!   testprop (hui, "fontweight", "4.6", "light");
%!   hui = uipanel ();
%!   testprop (hui, "fontweight", "4.6", "demi");
%!   testprop (hui, "fontweight", "4.6", "light");
%!   hui = uibuttongroup ();
%!   testprop (hui, "fontweight", "4.6", "demi");
%!   testprop (hui, "fontweight", "4.6", "light");
%! unwind_protect_cleanup
%!   close (hf);
%! end_unwind_protect