Mercurial > octave
view libgui/graphics/PopupMenuControl.cc @ 29542:3d34b70b5a49
connect many Qt signals and slots without SIGNAL and SLOT macros
This changes switches most code in the libgui/src and libgui/graphics
directories to use the new Qt style of connecting signals and slots
that uses pointers to member functions or function objects instead of
strings to refer to the signal and slot functions. For an
introduction, see https://wiki.qt.io/New_Signal_Slot_Syntax.
There are many connections left to adapt. In some cases, there are
overloaded functions (or default parameters) that need to be handled.
Use of QOverload<> or an anonymous function should fix these. In
others, we are connecting to parent objects where we only have a
pointer to QWidget instead of a specific type of object. To fix
those, we need to either move the code that makes th connection to a
place where the actual types of both objects are known or pass more
specific types as the parent object. In a few cases, there appear to
real mismatches in the types of objects and the signal/slot
functions.
Files affected: ButtonControl.cc, ButtonGroup.cc, ContextMenu.cc,
EditControl.cc, Figure.cc, ListBoxControl.cc, Menu.cc, Object.cc,
ObjectProxy.cc, Panel.cc, PopupMenuControl.cc, PushTool.cc,
SliderControl.cc, Table.cc, ToggleTool.cc, ToolBar.cc,
annotation-dialog.cc, qt-graphics-toolkit.cc, color-picker.cc,
command-widget.cc, dialog.cc, documentation-bookmarks.cc,
documentation.cc, files-dock-widget.cc, find-files-dialog.cc,
history-dock-widget.cc, interpreter-qobject.cc, file-editor-tab.cc,
file-editor-tab.h, file-editor.cc, find-dialog.cc,
octave-qscintilla.cc, main-window.cc, octave-dock-widget.cc,
octave-qobject.cc, qt-interpreter-events.cc, set-path-dialog.cc,
set-path-model.cc, settings-dialog.cc, shortcut-manager.cc,
tab-bar.cc, variable-editor-model.cc, variable-editor.cc,
welcome-wizard.cc, welcome-wizard.h, workspace-view.cc, and
workspace-view.h.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Fri, 16 Apr 2021 23:06:32 -0400 |
parents | 0a5b15007766 |
children | 5b7e721844df |
line wrap: on
line source
//////////////////////////////////////////////////////////////////////// // // Copyright (C) 2011-2021 The Octave Project Developers // // See the file COPYRIGHT.md in the top-level directory of this // distribution or <https://octave.org/copyright/>. // // This file is part of Octave. // // Octave is free software: you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // Octave is distributed in the hope that it will be useful, but // WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with Octave; see the file COPYING. If not, see // <https://www.gnu.org/licenses/>. // //////////////////////////////////////////////////////////////////////// #if defined (HAVE_CONFIG_H) # include "config.h" #endif #include <QComboBox> #include "Container.h" #include "PopupMenuControl.h" #include "QtHandlesUtils.h" #include "octave-qobject.h" namespace QtHandles { PopupMenuControl* PopupMenuControl::create (octave::base_qobject& oct_qobj, octave::interpreter& interp, const graphics_object& go) { Object *parent = parentObject (interp, go); if (parent) { Container *container = parent->innerContainer (); if (container) return new PopupMenuControl (oct_qobj, interp, go, new QComboBox (container)); } return nullptr; } PopupMenuControl::PopupMenuControl (octave::base_qobject& oct_qobj, octave::interpreter& interp, const graphics_object& go, QComboBox *box) : BaseControl (oct_qobj, interp, go, box), m_blockUpdate (false) { uicontrol::properties& up = properties<uicontrol> (); box->addItems (Utils::fromStdString (up.get_string_string ()).split ('|')); update (uicontrol::properties::ID_VALUE); connect (box, QOverload<int>::of (&QComboBox::activated), this, &PopupMenuControl::currentIndexChanged); } PopupMenuControl::~PopupMenuControl (void) { } void PopupMenuControl::update (int pId) { uicontrol::properties& up = properties<uicontrol> (); QComboBox *box = qWidget<QComboBox> (); switch (pId) { case uicontrol::properties::ID_STRING: m_blockUpdate = true; { int oldCurrent = box->currentIndex (); box->clear (); box->addItems (Utils::fromStdString (up.get_string_string ()).split ('|')); if (box->count () > 0 && oldCurrent >= 0 && oldCurrent < box->count ()) { box->setCurrentIndex (oldCurrent); } else { emit gh_set_event (m_handle, "value", octave_value (box->count () > 0 ? 1.0 : 0.0), false); } } m_blockUpdate = false; break; case uicontrol::properties::ID_VALUE: m_blockUpdate = true; { Matrix value = up.get_value ().matrix_value (); if (value.numel () > 0) { if (value(0) != static_cast<int> (value(0))) warning ("popupmenu value should be integer"); else { int newIndex = int (value(0)) - 1; if (newIndex >= 0 && newIndex < box->count ()) { if (newIndex != box->currentIndex ()) box->setCurrentIndex (newIndex); } else warning ("popupmenu value not within valid display range"); } } } m_blockUpdate = false; break; default: BaseControl::update (pId); break; } } void PopupMenuControl::currentIndexChanged (int index) { if (! m_blockUpdate) { emit gh_set_event (m_handle, "value", octave_value (double (index + 1)), false); emit gh_callback_event (m_handle, "callback"); } } }