Mercurial > octave
view libinterp/corefcn/ls-utils.cc @ 31105:670a0d878af1
eliminate WHO arguments from interpreter-private functions
* interpreter-private.h, inpterpreter-private.cc (__get_interpreter__,
__get_dynamic_loader__, __get_error_system__, __get_gh_manager__,
__get_help_system__, __get_input_system__, __get_load_path__,
__get_load_save_system__, __get_event_manager__,
__get_output_system__, __get_type_info__, __get_symbol_table__,
__get_current_scope__, __require_current_scope__, __get_evaluator__,
__get_bp_table__, __get_child_list__, __get_cdef_manager__,
__get_display_info__, __get_gtk_manager__): Eliminate WHO argument.
Previously, it was never displayed by __get_interpreter__. And, as
pointed out by Petter Tomner in patch #10216, passing a std::string
object could have performance issues.
(__get_interpreter__): Eliminate useless call to error. Display
message to std::cerr then abort.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Wed, 22 Jun 2022 12:48:59 -0400 |
parents | 796f54d4ddbf |
children | e88a07dec498 |
line wrap: on
line source
//////////////////////////////////////////////////////////////////////// // // Copyright (C) 2003-2022 The Octave Project Developers // // See the file COPYRIGHT.md in the top-level directory of this // distribution or <https://octave.org/copyright/>. // // This file is part of Octave. // // Octave is free software: you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // Octave is distributed in the hope that it will be useful, but // WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with Octave; see the file COPYING. If not, see // <https://www.gnu.org/licenses/>. // //////////////////////////////////////////////////////////////////////// #if defined (HAVE_CONFIG_H) # include "config.h" #endif #include "data-conv.h" #include "ls-utils.h" OCTAVE_NAMESPACE_BEGIN // MAX_VAL and MIN_VAL are assumed to have integral values even though // they are stored in doubles. save_type get_save_type (double /* max_val */, double /* min_val */) { save_type st = LS_DOUBLE; // Matlab doesn't seem to load the UINT32 type correctly, so let's // avoid it (and the other unsigned types, even though they may not // have the same problem. And apparently, there are problems with // other smaller types as well. If we avoid them all, then maybe we // will avoid problems. Unfortunately, we won't be able to save // space... // if (max_val < 256 && min_val > -1) // st = LS_U_CHAR; // else if (max_val < 65536 && min_val > -1) // st = LS_U_SHORT; // else if (max_val < 4294967295UL && min_val > -1) // st = LS_U_INT; // else if (max_val < 128 && min_val >= -128) // st = LS_CHAR; // else if (max_val < 32768 && min_val >= -32768) // st = LS_SHORT; // else if (max_val <= 2147483647L && min_val >= -2147483647L) // st = LS_INT; return st; } save_type get_save_type (float /* max_val */, float /* min_val */) { save_type st = LS_FLOAT; // Matlab doesn't seem to load the UINT32 type correctly, so let's // avoid it (and the other unsigned types, even though they may not // have the same problem. And apparently, there are problems with // other smaller types as well. If we avoid them all, then maybe we // will avoid problems. Unfortunately, we won't be able to save // space... // if (max_val < 256 && min_val > -1) // st = LS_U_CHAR; // else if (max_val < 65536 && min_val > -1) // st = LS_U_SHORT; // else if (max_val < 4294967295UL && min_val > -1) // st = LS_U_INT; // else if (max_val < 128 && min_val >= -128) // st = LS_CHAR; // else if (max_val < 32768 && min_val >= -32768) // st = LS_SHORT; // else if (max_val <= 2147483647L && min_val >= -2147483647L) // st = LS_INT; return st; } OCTAVE_NAMESPACE_END