Mercurial > octave
view .gitattributes @ 29979:ac5e1b64f8c9
Resolve two FIXME notes in Array::sort routines.
FIXME note in sort routines wondered whether there was a performance impact
from testing for NaN values on integer types (which cannot have IEEE NaN
values). Performance testing reveals there is no slowdown to using the
function, presumably because library routines have a very quick shortcut
to eject integers from consideration.
* Array.cc (sort (dim, mode)): Add comment explaining special case for
"stride == 1". Add note for future programmers that no special case
is needed for integers to avoid sort_isnan() function call. Remove
FIXME notes about impact on integers.
* Array.cc (sort (sidx, dim, mode)): Add comment for "stride == 1"
pointing to further explanation in Array::sort (dim,mode). Remove
FIXME notes about impact on integers.
author | Rik <rik@octave.org> |
---|---|
date | Tue, 17 Aug 2021 09:12:20 -0700 |
parents | c6f9ff84dc84 |
children |