Mercurial > octave
view libgui/qterminal/libqterminal/QTerminal.h @ 31619:ad014fc78bd6
use individual local gui_settings objects
Previously, we created a single gui_settings object (derived from
QSettings) and accessed it from the resource_manager object. That
design is not necessary and is not the way QSettings was designed to
be used. Instead of managing a single object, we should be using
individual QSettings objects where needed. Each individual QSettings
object manages thread-safe access to a single global collection of
settings. The Qt docs say that operations on QSettings are not thread
safe, but that means that you can't create a QSettings object in one
thread and use it in another without some locking. I'm not sure
whether we were doing that correctly, but with this change it no
longer matters. Each QSettings object does perform locking when
reading or writing the underlying global data.
* resource-manager.h, resource-manager.cc
(resource_manager::m_settings): Delete data member.
(resource_manager::get_settings): Delete.
* annotation-dialog.cc, QTerminal.cc, QTerminal.h, command-widget.cc,
command-widget.h, community-news.cc, dialog.cc,
documentation-bookmarks.cc, documentation-bookmarks.h,
documentation-dock-widget.cc, documentation-dock-widget.h,
documentation.cc, documentation.h, dw-main-window.cc,
dw-main-window.h, external-editor-interface.cc, files-dock-widget.cc,
files-dock-widget.h, find-files-dialog.cc, history-dock-widget.cc,
history-dock-widget.h, file-editor-interface.h, file-editor-tab.cc,
file-editor-tab.h, file-editor.cc, file-editor.h, find-dialog.cc,
octave-qscintilla.cc, main-window.cc, main-window.h, news-reader.cc,
octave-dock-widget.cc, octave-dock-widget.h, qt-interpreter-events.cc,
qt-interpreter-events.h, release-notes.cc, resource-manager.cc,
resource-manager.h, set-path-dialog.cc, settings-dialog.cc,
settings-dialog.h, shortcut-manager.cc, shortcut-manager.h,
terminal-dock-widget.cc, terminal-dock-widget.h, variable-editor.cc,
variable-editor.h, welcome-wizard.cc, workspace-model.cc,
workspace-model.h, workspace-view.cc: Use local gui_settings objects
instead of accessing a pointer to a single gui_settings object owned
by the resource_manager object.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Fri, 02 Dec 2022 14:23:53 -0500 |
parents | 5154c91e0d98 |
children | dd904ce6f53f |
line wrap: on
line source
/* Copyright (C) 2012-2019 Michael Goffioul. Copyright (C) 2012-2019 Jacob Dawid. This file is part of QTerminal. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. */ #ifndef QTERMINAL_H #define QTERMINAL_H #include <QColor> #include <QList> #include <QPoint> #include <QString> #include <QWidget> namespace octave { class base_qobject; } class QMenu; class QAction; class QTerminal : public QWidget { Q_OBJECT public: static QTerminal * create (octave::base_qobject& oct_qobj, QWidget *xparent); virtual ~QTerminal (void) = default; virtual void setTerminalFont (const QFont& font) = 0; virtual void setSize (int h, int v) = 0; virtual void sendText (const QString& text) = 0; virtual QString selectedText () = 0; virtual void has_extra_interrupt (bool extra) = 0; virtual QList<QAction*> get_hotspot_actions (const QPoint&) { return QList<QAction*> (); } enum CursorType { IBeamCursor, BlockCursor, UnderlineCursor }; virtual void setCursorType (CursorType type, bool blinking) { // Provide empty default impl in order to avoid conflicts with the // win impl. Q_UNUSED (type); Q_UNUSED (blinking); } virtual void setBackgroundColor (const QColor& color) = 0; virtual void setForegroundColor (const QColor& color) = 0; virtual void setSelectionColor (const QColor& color) = 0; virtual void setCursorColor (bool useForegroundColor, const QColor& color) = 0; virtual void setScrollBufferSize(int value=1000) = 0; signals: void report_status_message (const QString&); void interrupt_signal (void); void edit_mfile_request (const QString&, int); void show_doc_signal (const QString&); void execute_command_in_terminal_signal (const QString&); void request_edit_mfile_signal (const QString&, int); void request_open_file_signal (const QString&, const QString&, int); void set_screen_size_signal (int, int); void clear_command_window_request (void); public slots: virtual void copyClipboard (void) = 0; virtual void pasteClipboard (void) = 0; virtual void selectAll (void) = 0; virtual void handleCustomContextMenuRequested (const QPoint& at); void notice_settings (void); virtual void init_terminal_size (void) { } void terminal_interrupt (void) { emit interrupt_signal (); } void run_selection (void); void edit_file (void); void edit_selected (void); void help_on_expression (void); void doc_on_expression (void); virtual void handle_visibility_changed (bool) { }; protected: QTerminal (octave::base_qobject& oct_qobj, QWidget *xparent = nullptr) : QWidget (xparent), m_octave_qobj (oct_qobj) { } void construct (octave::base_qobject& oct_qobj); private: octave::base_qobject& m_octave_qobj; QMenu *_contextMenu; QAction * _copy_action; QAction * _paste_action; QAction * _selectall_action; QAction * _edit_action; QAction * _run_selection_action; QAction * m_edit_selected_action; QAction * m_help_selected_action; QAction * m_doc_selected_action; QAction *_interrupt_action; QAction *_nop_action; }; #endif // QTERMINAL_H