Mercurial > octave
view libgui/src/m-editor/file-editor-interface.h @ 31619:ad014fc78bd6
use individual local gui_settings objects
Previously, we created a single gui_settings object (derived from
QSettings) and accessed it from the resource_manager object. That
design is not necessary and is not the way QSettings was designed to
be used. Instead of managing a single object, we should be using
individual QSettings objects where needed. Each individual QSettings
object manages thread-safe access to a single global collection of
settings. The Qt docs say that operations on QSettings are not thread
safe, but that means that you can't create a QSettings object in one
thread and use it in another without some locking. I'm not sure
whether we were doing that correctly, but with this change it no
longer matters. Each QSettings object does perform locking when
reading or writing the underlying global data.
* resource-manager.h, resource-manager.cc
(resource_manager::m_settings): Delete data member.
(resource_manager::get_settings): Delete.
* annotation-dialog.cc, QTerminal.cc, QTerminal.h, command-widget.cc,
command-widget.h, community-news.cc, dialog.cc,
documentation-bookmarks.cc, documentation-bookmarks.h,
documentation-dock-widget.cc, documentation-dock-widget.h,
documentation.cc, documentation.h, dw-main-window.cc,
dw-main-window.h, external-editor-interface.cc, files-dock-widget.cc,
files-dock-widget.h, find-files-dialog.cc, history-dock-widget.cc,
history-dock-widget.h, file-editor-interface.h, file-editor-tab.cc,
file-editor-tab.h, file-editor.cc, file-editor.h, find-dialog.cc,
octave-qscintilla.cc, main-window.cc, main-window.h, news-reader.cc,
octave-dock-widget.cc, octave-dock-widget.h, qt-interpreter-events.cc,
qt-interpreter-events.h, release-notes.cc, resource-manager.cc,
resource-manager.h, set-path-dialog.cc, settings-dialog.cc,
settings-dialog.h, shortcut-manager.cc, shortcut-manager.h,
terminal-dock-widget.cc, terminal-dock-widget.h, variable-editor.cc,
variable-editor.h, welcome-wizard.cc, workspace-model.cc,
workspace-model.h, workspace-view.cc: Use local gui_settings objects
instead of accessing a pointer to a single gui_settings object owned
by the resource_manager object.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Fri, 02 Dec 2022 14:23:53 -0500 |
parents | c6c4c6f04170 |
children | 431f80aba37a |
line wrap: on
line source
//////////////////////////////////////////////////////////////////////// // // Copyright (C) 2011-2022 The Octave Project Developers // // See the file COPYRIGHT.md in the top-level directory of this // distribution or <https://octave.org/copyright/>. // // This file is part of Octave. // // Octave is free software: you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // Octave is distributed in the hope that it will be useful, but // WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with Octave; see the file COPYING. If not, see // <https://www.gnu.org/licenses/>. // //////////////////////////////////////////////////////////////////////// #if ! defined (octave_file_editor_interface_h) #define octave_file_editor_interface_h 1 #include <QMenu> #include <QMenuBar> #include <QToolBar> #include "octave-dock-widget.h" namespace octave { class base_qobject; class file_editor_interface : public octave_dock_widget { Q_OBJECT public: file_editor_interface (QWidget *p, base_qobject& oct_qobj) : octave_dock_widget ("FileEditor", p, oct_qobj) { } virtual ~file_editor_interface (void) = default; virtual QMenu * get_mru_menu (void) = 0; virtual QMenu * debug_menu (void) = 0; virtual QToolBar * toolbar (void) = 0; virtual QMenuBar * menubar (void) = 0; virtual void insert_global_actions (QList<QAction *>) = 0; virtual void handle_enter_debug_mode (void) = 0; virtual void handle_exit_debug_mode (void) = 0; virtual void handle_insert_debugger_pointer_request (const QString& file, int line) = 0; virtual void handle_delete_debugger_pointer_request (const QString& file, int line) = 0; virtual void handle_update_breakpoint_marker_request (bool insert, const QString& file, int line, const QString& cond) = 0; virtual void handle_edit_file_request (const QString& file) = 0; virtual bool check_closing (void) = 0; virtual void empty_script (bool, bool) = 0; virtual void restore_session (void) = 0; virtual void enable_menu_shortcuts (bool enable) = 0; signals: void interpreter_event (const fcn_callback& fcn); void interpreter_event (const meth_callback& meth); public slots: virtual void toplevel_change (bool) = 0; virtual void handle_file_remove (const QString& o, const QString& n) = 0; virtual void request_new_file (const QString& command = QString ()) = 0; virtual void request_open_file (const QString& openFileName, const QString& encoding = QString (), int line = -1, bool debug_pointer = false, bool breakpoint_marker = false, bool insert = true, const QString& cond = "", int index = -1, const QString& bookmarks = QString ()) = 0; }; } #endif