Mercurial > octave
view libgui/src/news-reader.cc @ 31619:ad014fc78bd6
use individual local gui_settings objects
Previously, we created a single gui_settings object (derived from
QSettings) and accessed it from the resource_manager object. That
design is not necessary and is not the way QSettings was designed to
be used. Instead of managing a single object, we should be using
individual QSettings objects where needed. Each individual QSettings
object manages thread-safe access to a single global collection of
settings. The Qt docs say that operations on QSettings are not thread
safe, but that means that you can't create a QSettings object in one
thread and use it in another without some locking. I'm not sure
whether we were doing that correctly, but with this change it no
longer matters. Each QSettings object does perform locking when
reading or writing the underlying global data.
* resource-manager.h, resource-manager.cc
(resource_manager::m_settings): Delete data member.
(resource_manager::get_settings): Delete.
* annotation-dialog.cc, QTerminal.cc, QTerminal.h, command-widget.cc,
command-widget.h, community-news.cc, dialog.cc,
documentation-bookmarks.cc, documentation-bookmarks.h,
documentation-dock-widget.cc, documentation-dock-widget.h,
documentation.cc, documentation.h, dw-main-window.cc,
dw-main-window.h, external-editor-interface.cc, files-dock-widget.cc,
files-dock-widget.h, find-files-dialog.cc, history-dock-widget.cc,
history-dock-widget.h, file-editor-interface.h, file-editor-tab.cc,
file-editor-tab.h, file-editor.cc, file-editor.h, find-dialog.cc,
octave-qscintilla.cc, main-window.cc, main-window.h, news-reader.cc,
octave-dock-widget.cc, octave-dock-widget.h, qt-interpreter-events.cc,
qt-interpreter-events.h, release-notes.cc, resource-manager.cc,
resource-manager.h, set-path-dialog.cc, settings-dialog.cc,
settings-dialog.h, shortcut-manager.cc, shortcut-manager.h,
terminal-dock-widget.cc, terminal-dock-widget.h, variable-editor.cc,
variable-editor.h, welcome-wizard.cc, workspace-model.cc,
workspace-model.h, workspace-view.cc: Use local gui_settings objects
instead of accessing a pointer to a single gui_settings object owned
by the resource_manager object.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Fri, 02 Dec 2022 14:23:53 -0500 |
parents | 796f54d4ddbf |
children | ca7d58406f82 |
line wrap: on
line source
//////////////////////////////////////////////////////////////////////// // // Copyright (C) 2011-2022 The Octave Project Developers // // See the file COPYRIGHT.md in the top-level directory of this // distribution or <https://octave.org/copyright/>. // // This file is part of Octave. // // Octave is free software: you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // Octave is distributed in the hope that it will be useful, but // WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with Octave; see the file COPYING. If not, see // <https://www.gnu.org/licenses/>. // //////////////////////////////////////////////////////////////////////// #if defined (HAVE_CONFIG_H) # include "config.h" #endif #include <string> #include <QDateTime> #include <QString> #include "news-reader.h" #include "octave-qobject.h" #include "gui-preferences-nr.h" #include "gui-settings.h" #include "url-transfer.h" #include "version.h" namespace octave { void news_reader::process (void) { QString html_text; if (m_connect_to_web) { // Run this part in a separate thread so Octave can continue to // run while we wait for the page to load. Then emit the signal // to display it when we have the page contents. QString url = m_base_url + '/' + m_page; std::ostringstream buf; url_transfer octave_dot_org (url.toStdString (), buf); if (octave_dot_org.is_valid ()) { Array<std::string> param; octave_dot_org.http_get (param); if (octave_dot_org.good ()) html_text = QString::fromStdString (buf.str ()); } if (html_text.contains ("this-is-the-gnu-octave-community-news-page")) { if (m_serial >= 0) { gui_settings settings; settings.setValue (nr_last_time.key, QDateTime::currentDateTime ()); settings.sync (); QString tag ("community-news-page-serial="); int b = html_text.indexOf (tag); if (b) { b += tag.length (); int e = html_text.indexOf ("\n", b); QString tmp = html_text.mid (b, e-b); int curr_page_serial = tmp.toInt (); if (curr_page_serial > m_serial) { settings.setValue (nr_last_news.key, curr_page_serial); settings.sync (); } else return; } else return; } } else html_text = QString (tr ("<html>\n" "<body>\n" "<p>\n" "Octave's community news source seems to be unavailable.\n" "</p>\n" "<p>\n" "For the latest news, please check\n" "<a href=\"https://octave.org/community-news.html\">https://octave.org/community-news.html</a>\n" "when you have a connection to the web (link opens in an external browser).\n" "</p>\n" "<p>\n" "<small><em>— The Octave Developers, ") + OCTAVE_RELEASE_DATE + "</em></small>\n" "</p>\n" "</body>\n" "</html>\n"); } else html_text = QString (tr ("<html>\n" "<body>\n" "<p>\n" "Connecting to the web to display the latest Octave Community news has been disabled.\n" "</p>\n" "<p>\n" "For the latest news, please check\n" "<a href=\"https://octave.org/community-news.html\">https://octave.org/community-news.html</a>\n" "when you have a connection to the web (link opens in an external browser)\n" "or enable web connections for news in Octave's network settings dialog.\n" "</p>\n" "<p>\n" "<small><em>— The Octave Developers, ") + OCTAVE_RELEASE_DATE + "</em></small>\n" "</p>\n" "</body>\n" "</html>\n"); emit display_news_signal (html_text); emit finished (); } }