view libgui/src/settings-dialog.h @ 31619:ad014fc78bd6

use individual local gui_settings objects Previously, we created a single gui_settings object (derived from QSettings) and accessed it from the resource_manager object. That design is not necessary and is not the way QSettings was designed to be used. Instead of managing a single object, we should be using individual QSettings objects where needed. Each individual QSettings object manages thread-safe access to a single global collection of settings. The Qt docs say that operations on QSettings are not thread safe, but that means that you can't create a QSettings object in one thread and use it in another without some locking. I'm not sure whether we were doing that correctly, but with this change it no longer matters. Each QSettings object does perform locking when reading or writing the underlying global data. * resource-manager.h, resource-manager.cc (resource_manager::m_settings): Delete data member. (resource_manager::get_settings): Delete. * annotation-dialog.cc, QTerminal.cc, QTerminal.h, command-widget.cc, command-widget.h, community-news.cc, dialog.cc, documentation-bookmarks.cc, documentation-bookmarks.h, documentation-dock-widget.cc, documentation-dock-widget.h, documentation.cc, documentation.h, dw-main-window.cc, dw-main-window.h, external-editor-interface.cc, files-dock-widget.cc, files-dock-widget.h, find-files-dialog.cc, history-dock-widget.cc, history-dock-widget.h, file-editor-interface.h, file-editor-tab.cc, file-editor-tab.h, file-editor.cc, file-editor.h, find-dialog.cc, octave-qscintilla.cc, main-window.cc, main-window.h, news-reader.cc, octave-dock-widget.cc, octave-dock-widget.h, qt-interpreter-events.cc, qt-interpreter-events.h, release-notes.cc, resource-manager.cc, resource-manager.h, set-path-dialog.cc, settings-dialog.cc, settings-dialog.h, shortcut-manager.cc, shortcut-manager.h, terminal-dock-widget.cc, terminal-dock-widget.h, variable-editor.cc, variable-editor.h, welcome-wizard.cc, workspace-model.cc, workspace-model.h, workspace-view.cc: Use local gui_settings objects instead of accessing a pointer to a single gui_settings object owned by the resource_manager object.
author John W. Eaton <jwe@octave.org>
date Fri, 02 Dec 2022 14:23:53 -0500
parents 796f54d4ddbf
children 431f80aba37a
line wrap: on
line source

////////////////////////////////////////////////////////////////////////
//
// Copyright (C) 2011-2022 The Octave Project Developers
//
// See the file COPYRIGHT.md in the top-level directory of this
// distribution or <https://octave.org/copyright/>.
//
// This file is part of Octave.
//
// Octave is free software: you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Octave is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Octave; see the file COPYING.  If not, see
// <https://www.gnu.org/licenses/>.
//
////////////////////////////////////////////////////////////////////////

#if ! defined (octave_settings_dialog_h)
#define octave_settings_dialog_h 1

#include <QCheckBox>
#include <QDialog>
#include <QLineEdit>
#include <QRadioButton>

#include "color-picker.h"
#include "gui-preferences-ed.h"
#include "ui-settings-dialog.h"

class QsciLexer;

namespace octave
{
  class base_qobject;

  // Ui::settings_dialog is a generated class.

  class settings_dialog : public QDialog, private Ui::settings_dialog
  {
  Q_OBJECT public:

    explicit settings_dialog (QWidget *parent, base_qobject& octave_qobj,
                              const QString& desired_tab = QString ());

    ~settings_dialog (void) = default;

    void show_tab (const QString&);

  signals:

    void apply_new_settings (void);

  private slots:

    void get_octave_dir (void);
    void get_file_browser_dir (void);
    void get_dir (QLineEdit *, const QString&);
    void set_disabled_pref_file_browser_dir (bool disable);
    void proxy_items_update (void);

    // slots updating colors depending on theme
    void update_terminal_colors (int def = 0);
    void update_workspace_colors (int def = 0);
    void update_varedit_colors (int def = 0);
    void update_editor_lexers (int def = 0);

    // slots for dialog's buttons
    void button_clicked (QAbstractButton *button);

    // slots for import/export-buttons of shortcut sets
    void import_shortcut_set (void);
    void export_shortcut_set (void);
    void default_shortcut_set (void);

  private:

#if defined (HAVE_QSCINTILLA)
    void update_lexer (QsciLexer *lexer, int mode, int def = 0);
    void get_lexer_settings (QsciLexer *lexer);
    void write_lexer_settings (QsciLexer *lexer);
#endif

    void write_changed_settings (bool closing);

    void read_workspace_colors (void);
    void write_workspace_colors (void);

    void read_terminal_colors (void);
    void write_terminal_colors (void);

    void read_varedit_colors (void);
    void write_varedit_colors (void);

    base_qobject& m_octave_qobj;

    color_picker *m_widget_title_bg_color;
    color_picker *m_widget_title_bg_color_active;
    color_picker *m_widget_title_fg_color;
    color_picker *m_widget_title_fg_color_active;

    QRadioButton *m_rb_comment_strings[ed_comment_strings_count];
    QCheckBox *m_rb_uncomment_strings[ed_comment_strings_count];

    QCheckBox *m_ws_enable_colors;
    QCheckBox *m_ws_hide_tool_tips;
  };
}

#endif