Mercurial > octave
view libgui/src/workspace-view.h @ 31619:ad014fc78bd6
use individual local gui_settings objects
Previously, we created a single gui_settings object (derived from
QSettings) and accessed it from the resource_manager object. That
design is not necessary and is not the way QSettings was designed to
be used. Instead of managing a single object, we should be using
individual QSettings objects where needed. Each individual QSettings
object manages thread-safe access to a single global collection of
settings. The Qt docs say that operations on QSettings are not thread
safe, but that means that you can't create a QSettings object in one
thread and use it in another without some locking. I'm not sure
whether we were doing that correctly, but with this change it no
longer matters. Each QSettings object does perform locking when
reading or writing the underlying global data.
* resource-manager.h, resource-manager.cc
(resource_manager::m_settings): Delete data member.
(resource_manager::get_settings): Delete.
* annotation-dialog.cc, QTerminal.cc, QTerminal.h, command-widget.cc,
command-widget.h, community-news.cc, dialog.cc,
documentation-bookmarks.cc, documentation-bookmarks.h,
documentation-dock-widget.cc, documentation-dock-widget.h,
documentation.cc, documentation.h, dw-main-window.cc,
dw-main-window.h, external-editor-interface.cc, files-dock-widget.cc,
files-dock-widget.h, find-files-dialog.cc, history-dock-widget.cc,
history-dock-widget.h, file-editor-interface.h, file-editor-tab.cc,
file-editor-tab.h, file-editor.cc, file-editor.h, find-dialog.cc,
octave-qscintilla.cc, main-window.cc, main-window.h, news-reader.cc,
octave-dock-widget.cc, octave-dock-widget.h, qt-interpreter-events.cc,
qt-interpreter-events.h, release-notes.cc, resource-manager.cc,
resource-manager.h, set-path-dialog.cc, settings-dialog.cc,
settings-dialog.h, shortcut-manager.cc, shortcut-manager.h,
terminal-dock-widget.cc, terminal-dock-widget.h, variable-editor.cc,
variable-editor.h, welcome-wizard.cc, workspace-model.cc,
workspace-model.h, workspace-view.cc: Use local gui_settings objects
instead of accessing a pointer to a single gui_settings object owned
by the resource_manager object.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Fri, 02 Dec 2022 14:23:53 -0500 |
parents | 796f54d4ddbf |
children | 431f80aba37a |
line wrap: on
line source
//////////////////////////////////////////////////////////////////////// // // Copyright (C) 2011-2022 The Octave Project Developers // // See the file COPYRIGHT.md in the top-level directory of this // distribution or <https://octave.org/copyright/>. // // This file is part of Octave. // // Octave is free software: you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // Octave is distributed in the hope that it will be useful, but // WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with Octave; see the file COPYING. If not, see // <https://www.gnu.org/licenses/>. // //////////////////////////////////////////////////////////////////////// #if ! defined (octave_workspace_view_h) #define octave_workspace_view_h 1 #include <QCheckBox> #include <QComboBox> #include <QItemDelegate> #include <QSemaphore> #include <QSignalMapper> #include <QSortFilterProxyModel> #include <QTableView> #include "octave-dock-widget.h" #include "workspace-model.h" namespace octave { class base_qobject; class workspace_view : public octave_dock_widget { Q_OBJECT public: workspace_view (QWidget *parent, base_qobject& oct_qobj); ~workspace_view (void) = default; signals: //! Signal that user had requested a command on a variable. void command_requested (const QString& cmd); //! Signal that user wnats to copy a variable value to the //! clipboard. void copy_variable_value_to_clipboard (const QString&); //! Signal that user wants to rename a variable. void rename_variable_signal (const QString&, const QString&); //! Signal that user wants to edit a variable. void edit_variable_signal (const QString&); public slots: void setModel (workspace_model *model); void notice_settings (void); void save_settings (void); protected slots: void filter_update (const QString& expression); void filter_activate (bool enable); void update_filter_history (void); void header_contextmenu_requested (const QPoint& mpos); void toggle_header (int column); void contextmenu_requested (const QPoint& pos); void handle_contextmenu_copy (void); void handle_contextmenu_copy_value (void); void handle_contextmenu_rename (void); void handle_contextmenu_edit (void); void handle_contextmenu_clear (void); void handle_contextmenu_disp (void); void handle_contextmenu_plot (void); void handle_contextmenu_stem (void); void handle_contextmenu_filter (void); public slots: void handle_model_changed (void); void copyClipboard (void); void selectAll (void); private: void relay_contextmenu_command (const QString& cmdname, bool str = false); void set_filter_focus (bool focus); QString get_var_name (const QModelIndex& index); QTableView *m_view; int m_view_previous_row_count; // We are using a sort model proxy so m_model won't provide the // correct ordering. It is still OK to use this pointer to access // other info attached to the model, for example the scope or colors. workspace_model *m_model; QSortFilterProxyModel m_filter_model; QCheckBox *m_filter_checkbox; QComboBox *m_filter; QWidget *m_filter_widget; bool m_filter_shown; }; } #endif