Mercurial > octave
view libgui/src/community-news.cc @ 31639:ca7d58406f82
eliminate unnecessary uses of octave_qobject in GUI classes
* BaseControl.cc, BaseControl.h, ButtonControl.cc, ButtonControl.h,
ButtonGroup.cc, ButtonGroup.h, Canvas.cc, Canvas.h,
CheckBoxControl.cc, CheckBoxControl.h, Container.cc, Container.h,
ContextMenu.cc, ContextMenu.h, EditControl.cc, EditControl.h,
Figure.cc, Figure.h, GLCanvas.cc, GLCanvas.h, ListBoxControl.cc,
ListBoxControl.h, Menu.cc, Menu.h, Object.cc, Object.h, Panel.cc,
Panel.h, PopupMenuControl.cc, PopupMenuControl.h,
PushButtonControl.cc, PushButtonControl.h, PushTool.cc, PushTool.h,
RadioButtonControl.cc, RadioButtonControl.h, SliderControl.cc,
SliderControl.h, Table.cc, Table.h, TextControl.cc, TextControl.h,
ToggleButtonControl.cc, ToggleButtonControl.h, ToggleTool.cc,
ToggleTool.h, ToolBar.cc, ToolBar.h, ToolBarButton.cc,
ToolBarButton.h, annotation-dialog.cc, annotation-dialog.h,
qt-graphics-toolkit.cc, qt-graphics-toolkit.h, command-widget.h,
community-news.cc, community-news.h, documentation-bookmarks.cc,
documentation-bookmarks.h, documentation.cc,
external-editor-interface.cc, external-editor-interface.h,
find-files-dialog.cc, find-files-dialog.h, graphics-init.cc,
graphics-init.h, interpreter-qobject.cc, file-editor.cc,
find-dialog.cc, find-dialog.h, main-window.cc, main-window.h,
news-reader.cc, news-reader.h, octave-qobject.cc, release-notes.cc,
resource-manager.cc, set-path-dialog.cc, set-path-dialog.h,
shortcut-manager.cc, shortcut-manager.h, welcome-wizard.cc,
welcome-wizard.h, workspace-model.cc:
Don't store references to octave_qobject in GUI classes where it is
no longer needed. Eliminate unnecessary octave_qobject constructor
arguments. Change all uses.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Sun, 04 Dec 2022 22:57:02 -0500 |
parents | ad014fc78bd6 |
children | 431f80aba37a |
line wrap: on
line source
//////////////////////////////////////////////////////////////////////// // // Copyright (C) 2011-2022 The Octave Project Developers // // See the file COPYRIGHT.md in the top-level directory of this // distribution or <https://octave.org/copyright/>. // // This file is part of Octave. // // Octave is free software: you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // Octave is distributed in the hope that it will be useful, but // WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with Octave; see the file COPYING. If not, see // <https://www.gnu.org/licenses/>. // //////////////////////////////////////////////////////////////////////// #if defined (HAVE_CONFIG_H) # include "config.h" #endif #include <QLayout> #include <QTextBrowser> #include <QThread> #include "community-news.h" #include "gui-utils.h" #include "gui-preferences-dw.h" #include "gui-preferences-nr.h" #include "gui-settings.h" #include "news-reader.h" namespace octave { community_news::community_news (int serial) : QWidget (nullptr), m_browser (nullptr) { construct ("https://octave.org", "community-news.html", serial); } community_news::community_news (QWidget *parent, const QString& base_url, const QString& page, int serial) : QWidget (parent), m_browser (nullptr) { construct (base_url, page, serial); } void community_news::construct (const QString& base_url, const QString& page, int serial) { m_browser = new QTextBrowser (this); m_browser->setObjectName ("OctaveNews"); m_browser->setOpenExternalLinks (true); QVBoxLayout *vlayout = new QVBoxLayout; vlayout->addWidget (m_browser); setLayout (vlayout); setWindowTitle (tr ("Octave Community News")); int win_x, win_y; get_screen_geometry (win_x, win_y); resize (win_x/2, win_y/2); move ((win_x - width ())/2, (win_y - height ())/2); gui_settings settings; QString icon; QString icon_set = settings.value (dw_icon_set).toString (); if (icon_set != "NONE") // No extra icon for Community news, take the one of the release notes icon = dw_icon_set_names[icon_set] + "ReleaseWidget.png"; else icon = dw_icon_set_names[icon_set]; setWindowIcon (QIcon (icon)); // FIXME: This is a news reader preference, so shouldn't it be used // in the news_reader object? bool connect_to_web = settings.value (nr_allow_connection).toBool (); QThread *worker_thread = new QThread; news_reader *reader = new news_reader (base_url, page, serial, connect_to_web); reader->moveToThread (worker_thread); connect (reader, &news_reader::display_news_signal, this, &community_news::set_news); connect (worker_thread, &QThread::started, reader, &news_reader::process); connect (reader, &news_reader::finished, worker_thread, &QThread::quit); connect (reader, &news_reader::finished, reader, &news_reader::deleteLater); connect (worker_thread, &QThread::finished, worker_thread, &QThread::deleteLater); worker_thread->start (); } void community_news::set_news (const QString& news) { m_browser->setHtml (news); } void community_news::display (void) { if (! isVisible ()) show (); else if (isMinimized ()) showNormal (); raise (); activateWindow (); } }