Mercurial > octave
view libgui/src/external-editor-interface.cc @ 31639:ca7d58406f82
eliminate unnecessary uses of octave_qobject in GUI classes
* BaseControl.cc, BaseControl.h, ButtonControl.cc, ButtonControl.h,
ButtonGroup.cc, ButtonGroup.h, Canvas.cc, Canvas.h,
CheckBoxControl.cc, CheckBoxControl.h, Container.cc, Container.h,
ContextMenu.cc, ContextMenu.h, EditControl.cc, EditControl.h,
Figure.cc, Figure.h, GLCanvas.cc, GLCanvas.h, ListBoxControl.cc,
ListBoxControl.h, Menu.cc, Menu.h, Object.cc, Object.h, Panel.cc,
Panel.h, PopupMenuControl.cc, PopupMenuControl.h,
PushButtonControl.cc, PushButtonControl.h, PushTool.cc, PushTool.h,
RadioButtonControl.cc, RadioButtonControl.h, SliderControl.cc,
SliderControl.h, Table.cc, Table.h, TextControl.cc, TextControl.h,
ToggleButtonControl.cc, ToggleButtonControl.h, ToggleTool.cc,
ToggleTool.h, ToolBar.cc, ToolBar.h, ToolBarButton.cc,
ToolBarButton.h, annotation-dialog.cc, annotation-dialog.h,
qt-graphics-toolkit.cc, qt-graphics-toolkit.h, command-widget.h,
community-news.cc, community-news.h, documentation-bookmarks.cc,
documentation-bookmarks.h, documentation.cc,
external-editor-interface.cc, external-editor-interface.h,
find-files-dialog.cc, find-files-dialog.h, graphics-init.cc,
graphics-init.h, interpreter-qobject.cc, file-editor.cc,
find-dialog.cc, find-dialog.h, main-window.cc, main-window.h,
news-reader.cc, news-reader.h, octave-qobject.cc, release-notes.cc,
resource-manager.cc, set-path-dialog.cc, set-path-dialog.h,
shortcut-manager.cc, shortcut-manager.h, welcome-wizard.cc,
welcome-wizard.h, workspace-model.cc:
Don't store references to octave_qobject in GUI classes where it is
no longer needed. Eliminate unnecessary octave_qobject constructor
arguments. Change all uses.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Sun, 04 Dec 2022 22:57:02 -0500 |
parents | ad014fc78bd6 |
children | 431f80aba37a |
line wrap: on
line source
//////////////////////////////////////////////////////////////////////// // // Copyright (C) 2017-2022 The Octave Project Developers // // See the file COPYRIGHT.md in the top-level directory of this // distribution or <https://octave.org/copyright/>. // // This file is part of Octave. // // Octave is free software: you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // Octave is distributed in the hope that it will be useful, but // WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with Octave; see the file COPYING. If not, see // <https://www.gnu.org/licenses/>. // //////////////////////////////////////////////////////////////////////// #if defined (HAVE_CONFIG_H) # include "config.h" #endif #include <QMessageBox> #include <QProcess> #include "external-editor-interface.h" #include "gui-settings.h" #include "gui-preferences-global.h" namespace octave { external_editor_interface::external_editor_interface (QWidget *p) : QWidget (p) { } // Calling the external editor bool external_editor_interface::call_custom_editor (const QString& file, int line) { QString editor = external_editor (); if (editor.isEmpty ()) return true; if (line < 0) line = 0; // replace macros editor.replace ("%f", file); editor.replace ("%l", QString::number (line)); QStringList arguments = editor.split (QRegExp("\\s+")); editor = arguments.takeFirst (); // start the process and check for success bool started_ok = QProcess::startDetached (editor, arguments); if (started_ok != true) { QMessageBox *msgBox = new QMessageBox (QMessageBox::Critical, tr ("Octave Editor"), tr ("Could not start custom file editor\n%1"). arg (editor), QMessageBox::Ok); msgBox->setWindowModality (Qt::NonModal); msgBox->setAttribute (Qt::WA_DeleteOnClose); msgBox->show (); } return started_ok; } // Slots for the several signals for invoking the editor void external_editor_interface::request_new_file (const QString&) { call_custom_editor (); } void external_editor_interface::request_open_file (const QString& file_name, const QString&, int line, bool, bool, bool, const QString&) { call_custom_editor (file_name, line); } void external_editor_interface::handle_edit_file_request (const QString& file) { call_custom_editor (file); } // Get and verify the settings of the external editor program QString external_editor_interface::external_editor (void) { gui_settings settings; QString editor = settings.value (global_custom_editor.key, global_custom_editor.def).toString (); // check the settings (avoid an empty string) if (editor.trimmed ().isEmpty ()) { QMessageBox *msgBox = new QMessageBox (QMessageBox::Warning, tr ("Octave Editor"), tr ("There is no custom editor configured yet.\n" "Do you want to open the preferences?"), QMessageBox::No | QMessageBox::Yes); msgBox->setDefaultButton (QMessageBox::Yes); msgBox->setAttribute (Qt::WA_DeleteOnClose); int button = msgBox->exec (); if (button == QMessageBox::Yes) emit request_settings_dialog ("editor"); } return editor; } }