# HG changeset patch # User Arun Giridhar # Date 1715467680 14400 # Node ID 273cf7c2302ab76072da892100746d7903e95da8 # Parent a2ea7c2222b835d97dc6131657e4e90a5248534d fft.c: Remove FIXME and code after testing fft.c: A FIXME note was pointing out the strangeness of checking for negative dimensions. Running `hg annotate` on the file did not provide an explanation. Removing it and testing it did not show any problems. The loop has been removed along with the FIXME. diff -r a2ea7c2222b8 -r 273cf7c2302a libinterp/corefcn/fft.cc --- a/libinterp/corefcn/fft.cc Sat May 11 18:10:35 2024 -0400 +++ b/libinterp/corefcn/fft.cc Sat May 11 18:48:00 2024 -0400 @@ -79,13 +79,6 @@ dim = math::nint (dval) - 1; } - // FIXME: This seems strange and unnecessary (10/21/16). - // How would you ever arrive at an octave_value object without correct dims? - // We certainly don't make this check every other place in Octave. - for (octave_idx_type i = 0; i < ndims; i++) - if (dims(i) < 0) - return retval; - if (dim < 0) { dim = dims.first_non_singleton ();