# HG changeset patch # User John W. Eaton # Date 1589832743 14400 # Node ID 6349915869f27d82a23c10a97ab31714ca313c02 # Parent 5cb09ac94e81475709d3745197d24a7deb2bd9da move function definition from header to source file * stack-frame.h, stack-frame.cc (stack_frame::make_symbol_info_list): Move function definition from header to source file. diff -r 5cb09ac94e81 -r 6349915869f2 libinterp/corefcn/stack-frame.cc --- a/libinterp/corefcn/stack-frame.cc Mon May 18 16:10:52 2020 -0400 +++ b/libinterp/corefcn/stack-frame.cc Mon May 18 16:12:23 2020 -0400 @@ -247,6 +247,27 @@ panic_impossible (); } + symbol_info_list + stack_frame::make_symbol_info_list (const std::list& symrec_list) const + { + symbol_info_list symbol_stats; + + for (const auto& sym : symrec_list) + { + octave_value value = varval (sym); + + if (value.is_defined ()) + { + symbol_info syminf (sym.name (), value, sym.is_formal (), + is_global (sym), is_persistent (sym)); + + symbol_stats.append (syminf); + } + } + + return symbol_stats; + } + // Return first occurrence of variables in current stack frame and any // parent frames reachable through access links. diff -r 5cb09ac94e81 -r 6349915869f2 libinterp/corefcn/stack-frame.h --- a/libinterp/corefcn/stack-frame.h Mon May 18 16:10:52 2020 -0400 +++ b/libinterp/corefcn/stack-frame.h Mon May 18 16:12:23 2020 -0400 @@ -215,28 +215,8 @@ virtual unwind_protect * unwind_protect_frame (void) const { return nullptr; } - // FIXME: Should this function be private? - symbol_info_list - make_symbol_info_list (const std::list& symrec_list) const - { - symbol_info_list symbol_stats; - - for (const auto& sym : symrec_list) - { - octave_value value = varval (sym); - - if (value.is_defined ()) - { - symbol_info syminf (sym.name (), value, sym.is_formal (), - is_global (sym), is_persistent (sym)); - - symbol_stats.append (syminf); - } - } - - return symbol_stats; - } + make_symbol_info_list (const std::list& symrec_list) const; symbol_info_list all_variables (void);