# HG changeset patch
# User Torsten <mttl@mailbox.org>
# Date 1522784933 -7200
# Node ID 65b7380655f2c7e4f1e66003627e5cf09e918f3a
# Parent  29641449ca90bd3dcc34287ea5b6c849f78a7847
prevent crash if help data could not be set up (bug #53006)

* documentation.cc (documentation): return before creating documentation
  widget if help data failed to be set up;
  (~documentation): remove tmp files even if help engine is null pointer

diff -r 29641449ca90 -r 65b7380655f2 libgui/src/documentation.cc
--- a/libgui/src/documentation.cc	Tue Apr 03 21:48:33 2018 +0200
+++ b/libgui/src/documentation.cc	Tue Apr 03 21:48:53 2018 +0200
@@ -87,10 +87,9 @@
                                   "documentation viewer. Only help texts in\n"
                                   "the Console Widget will be available."));
         if (m_help_engine)
-          {
-            delete m_help_engine;
-            m_help_engine = 0;
-          }
+          delete m_help_engine;
+        m_help_engine = 0;
+        return;
       }
 
     // The browser
@@ -188,11 +187,12 @@
   documentation::~documentation (void)
   {
     if (m_help_engine)
-      {
-        delete m_help_engine;
+      delete m_help_engine;
 
-        // Cleanup temporary file and directory
-        QFile file (m_collection);
+    // Cleanup temporary file and directory
+    QFile file (m_collection);
+    if (file.exists ())
+      {
         QFileInfo finfo (file);
         QString bname = finfo.fileName ();
         QDir dir = finfo.absoluteDir ();