# HG changeset patch
# User Markus Mützel <markus.muetzel@gmx.de>
# Date 1647968486 -3600
# Node ID aaf689533e7bb661607754839fc95c0ab5bde6ca
# Parent  fc3bd70cd1bec23982300b1211f0b093b93b11e2
Avoid integer division by zero for int64 ranges with double increment.

* libinterp/octave-value/ov.cc (range_numel (T base, double increment, T limit)):
Check for wrap around after casting to unsigned integer type.
* test/range.tst: Un-comment tests.

diff -r fc3bd70cd1be -r aaf689533e7b libinterp/octave-value/ov.cc
--- a/libinterp/octave-value/ov.cc	Tue Mar 22 00:01:53 2022 -0400
+++ b/libinterp/octave-value/ov.cc	Tue Mar 22 18:01:26 2022 +0100
@@ -3255,6 +3255,11 @@
 
     UT unsigned_increment = range_increment<T> (increment);
 
+    // If the increment wasn't zero before but it is now, the cast to UT
+    // wrapped around. The range can only have one value.
+    if (unsigned_increment == 0)
+      return 1;
+
     return range_numel_aux (base, unsigned_increment, limit);
   }
 
diff -r fc3bd70cd1be -r aaf689533e7b test/range.tst
--- a/test/range.tst	Tue Mar 22 00:01:53 2022 -0400
+++ b/test/range.tst	Tue Mar 22 18:01:26 2022 +0100
@@ -613,9 +613,8 @@
 %! for i_type = 1:numel (types)
 %!   assert (intmin (types{i_type}) : -double (intmin (types{i_type})) : intmax (types{i_type}), ...
 %!           [intmin(types{i_type}), 0]);
-%!   ## FIXME: This test leads to a deadlock for "int64".
-%!   ## assert (intmin (types{i_type}) : -2*double (intmin (types{i_type})) : intmax (types{i_type}), ...
-%!   ##         intmin (types{i_type}));
+%!   assert (intmin (types{i_type}) : -2*double (intmin (types{i_type})) : intmax (types{i_type}), ...
+%!           intmin (types{i_type}));
 %!   if (! strcmp (types, "int64"))
 %!     ## The increment cannot be represented in double precision for "int64"
 %!     assert (intmin (types{i_type}) : 2*double (intmax (types{i_type})) : intmin (types{i_type}), ...
@@ -627,9 +626,8 @@
 %! for i_type = 1:numel (types)
 %!   assert (intmax (types{i_type}) : double (intmin (types{i_type})) : intmin (types{i_type}), ...
 %!           [intmax(types{i_type}), -1]);
-%!   ## FIXME: This test leads to a deadlock for "int64".
-%!   ## assert (intmax (types{i_type}) : 2*double (intmin (types{i_type})) : intmin (types{i_type}), ...
-%!   ##         intmax (types{i_type}));
+%!   assert (intmax (types{i_type}) : 2*double (intmin (types{i_type})) : intmin (types{i_type}), ...
+%!           intmax (types{i_type}));
 %!   if (! strcmp (types, "int64"))
 %!     ## The increment cannot be represented in double precision for "int64"
 %!     assert (intmax (types{i_type}) : -2*double (intmax (types{i_type})) : intmin (types{i_type}), ...