changeset 30088:fca57eaad2d4

maint: deprecate lo_ieee_finite and replace with lo_ieee_isfinite. * lo-ieee.h (__lo_ieee_isfinite): Replaces __lo_ieee_finite. * lo-ieee.h (__lo_ieee_float_isfinite): Replaces __lo_ieee_float_finite. * lo-ieee.h (#lo_ieee_isfinite): Replace macro lo_ieee_finite. * mex.cc (mxIsFinite): Use lo_ieee_isfinite macro.
author Rik <rik@octave.org>
date Mon, 30 Aug 2021 21:31:51 -0700
parents ad1739ca6ed4
children b0d67d613853
files libinterp/corefcn/mex.cc liboctave/util/lo-ieee.h
diffstat 2 files changed, 19 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/libinterp/corefcn/mex.cc	Mon Aug 30 16:17:18 2021 -0700
+++ b/libinterp/corefcn/mex.cc	Mon Aug 30 21:31:51 2021 -0700
@@ -3270,7 +3270,7 @@
 bool
 mxIsFinite (const double v)
 {
-  return lo_ieee_finite (v) != 0;
+  return lo_ieee_isfinite (v) != 0;
 }
 
 bool
--- a/liboctave/util/lo-ieee.h	Mon Aug 30 16:17:18 2021 -0700
+++ b/liboctave/util/lo-ieee.h	Mon Aug 30 21:31:51 2021 -0700
@@ -70,7 +70,7 @@
 extern OCTAVE_API void octave_ieee_init (void);
 
 inline int __lo_ieee_isnan (double x) { return std::isnan (x); }
-inline int __lo_ieee_finite (double x) { return std::isfinite (x); }
+inline int __lo_ieee_isfinite (double x) { return std::isfinite (x); }
 inline int __lo_ieee_isinf (double x) { return std::isinf (x); }
 
 extern OCTAVE_API int __lo_ieee_is_NA (double);
@@ -82,7 +82,7 @@
 inline int __lo_ieee_signbit (double x) { return std::signbit (x); }
 
 inline int __lo_ieee_float_isnan (float x) { return std::isnan (x); }
-inline int __lo_ieee_float_finite (float x) { return std::isfinite (x); }
+inline int __lo_ieee_float_isfinite (float x) { return std::isfinite (x); }
 inline int __lo_ieee_float_isinf (float x) { return std::isinf (x); }
 
 extern OCTAVE_API int __lo_ieee_float_is_NA (float);
@@ -101,9 +101,9 @@
   (sizeof (x) == sizeof (float)                         \
    ? __lo_ieee_float_isnan (x) : __lo_ieee_isnan (x))
 
-#define lo_ieee_finite(x)                               \
-  (sizeof (x) == sizeof (float)                         \
-   ? __lo_ieee_float_finite (x) : __lo_ieee_finite (x))
+#define lo_ieee_isfinite(x)                                   \
+  (sizeof (x) == sizeof (float)                               \
+   ? __lo_ieee_float_isfinite (x) : __lo_ieee_isfinite (x))
 
 #define lo_ieee_isinf(x)                                \
   (sizeof (x) == sizeof (float)                         \
@@ -152,4 +152,17 @@
 
 #endif
 
+#if defined (OCTAVE_PROVIDE_DEPRECATED_SYMBOLS)
+
+OCTAVE_DEPRECATED (7, "use '__lo_ieee_isfinite' instead")
+inline int __lo_ieee_finite (double x) { return __lo_ieee_isfinite (x); }
+
+OCTAVE_DEPRECATED (7, "use '__lo_ieee_float_isfinite' instead")
+inline int __lo_ieee_float_finite (float x)
+{ return __lo_ieee_float_isfinite (x); }
+
+#define lo_ieee_finite(x) lo_ieee_isfinite(x)
+
 #endif
+
+#endif