Mercurial > forge

changeset 6970:6c225f7615cb octave-forge

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
control: add two FIXME comments
author paramaniac
date Mon, 05 Apr 2010 09:11:31 +0000
parents 2749538747f7
children 4f232cd89aaa
files main/control/inst/@lti/sminreal.m main/control/inst/@ss/__minreal__.m
diffstat 2 files changed, 24 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/main/control/inst/@lti/sminreal.m	Mon Apr 05 00:56:37 2010 +0000
+++ b/main/control/inst/@lti/sminreal.m	Mon Apr 05 09:11:31 2010 +0000
@@ -43,4 +43,16 @@
 
   sys = __sysprune__ (sys, ":", ":", st_idx);
 
-endfunction
\ No newline at end of file
+endfunction
+
+
+## FIXME: algorithm returns wrong result for the example below
+##
+## P = ss (-2, 3, 4, 5)
+## C = inv (P)
+## L = P * C
+## Ls = sminreal (L)
+## bode (Ls)
+## 
+## Obviously, both magnitude and phase should be straight lines at 0 dB and 0 deg
+## In this case, sminreal shouldn't remove any states of L
\ No newline at end of file
--- a/main/control/inst/@ss/__minreal__.m	Mon Apr 05 00:56:37 2010 +0000
+++ b/main/control/inst/@ss/__minreal__.m	Mon Apr 05 09:11:31 2010 +0000
@@ -68,4 +68,14 @@
   retsys = ss (A, B, C, sys.d);
   retsys.lti = sys.lti;  # retain i/o names and tsam
 
-endfunction
\ No newline at end of file
+endfunction
+
+
+## FIXME: algorithm fails for the example below
+##
+## P = ss (-2, 3, 4, 5)
+## C = inv (P)
+## L = P * C
+## Lm = minreal (L)
+##
+## Lm.d should be 1
\ No newline at end of file